Address remaining SYCL review comments

Author: allnes

.github/workflows/static-analysis.yml

@@ -27,5 +27,18 @@ jobs:
             cmake --build build --parallel
     - name: Run clang-tidy
       run: |
-        mapfile -t sources < <(find app src -path 'app/SYCL' -prune -o -name '*.cpp' -print)
-        clang-tidy "${sources[@]}" -format-style=file -header-filter="($PWD/include/.*|$PWD/src/.*|$PWD/app/.*)" -p build
+        python3 - <<'PY'
+        import json
+        from pathlib import Path
+
+        compile_commands = json.loads(Path("build/compile_commands.json").read_text())
+        sources = sorted(
+            {
+                entry["file"]
+                for entry in compile_commands
+                if "/app/" in entry["file"] or "/src/" in entry["file"]
+            }
+        )
+        Path("build/clang_tidy_sources.txt").write_text("\n".join(sources) + "\n")
+        PY
+        xargs -a build/clang_tidy_sources.txt clang-tidy -format-style=file -header-filter="($PWD/include/.*|$PWD/src/.*|$PWD/app/.*)" -p build

CMakeLists.txt

@@ -42,6 +42,7 @@ find_package(OpenMP REQUIRED COMPONENTS CXX)
 
 if(OpenMP_FOUND)
     message(STATUS "OpenMP found - enabling parallel support")
+    add_definitions(-DHAS_OPENMP)
 else()
     message(STATUS "OpenMP not found - parallel features disabled")
 endif()

include/graph/runtime_options.hpp

@@ -1,5 +1,5 @@
 #pragma once
-#include <stdint.h>
+#include <cstdint>
 
 #include "parallel/parallel.hpp"
 

include/layers/ConcatLayer.hpp

@@ -1,6 +1,5 @@
 #pragma once
-#include <stdint.h>
-
+#include <cstdint>
 #include <numeric>
 #include <stdexcept>
 #include <vector>

include/layers/InputLayer.hpp

@@ -1,8 +1,7 @@
 #pragma once
-#include <stdint.h>
-
 #include <algorithm>
 #include <cmath>
+#include <cstdint>
 
 #include "layers/Layer.hpp"
 

include/layers/ReduceLayer.hpp

@@ -1,6 +1,5 @@
 #pragma once
-#include <stdint.h>
-
+#include <cstdint>
 #include <limits>
 #include <vector>
 

include/layers/Tensor.hpp

@@ -1,7 +1,6 @@
 #pragma once
 
-#include <stdint.h>
-
+#include <cstdint>
 #include <iostream>
 #include <stdexcept>
 #include <type_traits>

include/layers_oneDNN/ReduceLayer.hpp

@@ -1,6 +1,5 @@
 #pragma once
-#include <stdint.h>
-
+#include <cstdint>
 #include <dnnl.hpp>
 #include <memory>
 #include <vector>

include/parallel/backends.hpp

@@ -1,10 +1,9 @@
 #pragma once
-// clang-format off
-#include <stdint.h>
 #include <oneapi/tbb/blocked_range.h>
 #include <oneapi/tbb/info.h>
 #include <oneapi/tbb/parallel_for.h>
-// clang-format on
+
+#include <cstdint>
 
 // NOLINTNEXTLINE(misc-header-include-cycle)
 #include <Kokkos_Core.hpp>
@@ -17,7 +16,7 @@
 namespace it_lab_ai {
 namespace parallel {
 
-enum class Backend : uint8_t {
+enum class Backend : std::uint8_t {
   kSeq = 0,
   kThreads = 1,
   kTbb = 2,
@@ -94,7 +93,7 @@ inline void impl_tbb(std::size_t count,
   }, oneapi::tbb::auto_partitioner());
 }
 
-#ifdef _OPENMP
+#ifdef HAS_OPENMP
 inline void impl_omp(std::size_t count,
                      const std::function<void(std::size_t)>& func,
                      const Options& opt) {

include/parallel/parallel.hpp

@@ -5,7 +5,7 @@ namespace it_lab_ai {
 namespace parallel {
 
 constexpr bool kHasOmp =
-#ifdef _OPENMP
+#ifdef HAS_OPENMP
     true;
 #else
     false;
@@ -16,7 +16,7 @@ inline Backend resolve_default_backend(std::size_t n, const Options& opt) {
     return Backend::kSeq;
   }
 
-#ifdef _OPENMP
+#ifdef HAS_OPENMP
   return Backend::kOmp;
 #else
   return Backend::kTbb;