Skip to content

Commit 54f8d9a

Browse files
committed
ci: run full ctest suite like main (valgrind stays unit-only)
1 parent 013421c commit 54f8d9a

1 file changed

Lines changed: 7 additions & 30 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,14 @@ jobs:
8888
${{ steps.set_binaries.outputs.ACC_BINARY }}
8989
${{ matrix.build_dir }}/bin/all_libs/*
9090
- name: Test
91-
# TODO(aobolensk): re-enable perf-labeled tests in PR CI when runtime budget allows.
92-
run: ctest --preset ${{ matrix.preset }} --output-on-failure -L unit
91+
run: ctest --preset ${{ matrix.preset }} --output-on-failure
9392
env:
9493
CTEST_OUTPUT_ON_FAILURE: 1
9594
- name: Test (valgrind)
9695
run: |
9796
sudo apt-get update
9897
sudo apt-get install -y valgrind
98+
# Keep valgrind runtime bounded: run the unit subset (perf tests are still executed above).
9999
valgrind --error-exitcode=1 ${{ matrix.build_dir }}/bin/itlabai_run_test --gtest_filter=-convlayer_parall.*
100100
env:
101101
CTEST_OUTPUT_ON_FAILURE: 1
@@ -121,7 +121,7 @@ jobs:
121121
-DCMAKE_CXX_COMPILER=clang++
122122
cmake --build --preset release --parallel
123123
- name: Test
124-
run: ctest --preset release --output-on-failure -L unit
124+
run: ctest --preset release --output-on-failure
125125
env:
126126
CTEST_OUTPUT_ON_FAILURE: 1
127127
- name: Test (valgrind)
@@ -167,7 +167,7 @@ jobs:
167167
LDFLAGS: "-L$(brew --prefix libomp)/lib -lomp"
168168
CPPFLAGS: "-I$(brew --prefix libomp)/include"
169169
- name: Test
170-
run: ctest --preset release --output-on-failure -L unit
170+
run: ctest --preset release --output-on-failure
171171
env:
172172
CTEST_OUTPUT_ON_FAILURE: 1
173173
build-windows:
@@ -193,7 +193,7 @@ jobs:
193193
cmake --preset release -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
194194
cmake --build --preset release --parallel --config Release
195195
- name: Test
196-
run: ctest --preset release --output-on-failure -L unit
196+
run: ctest --preset release --output-on-failure
197197
build-linux-arm64:
198198
runs-on: ubuntu-24.04-arm
199199
steps:
@@ -212,7 +212,7 @@ jobs:
212212
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
213213
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache
214214
cmake --build --preset release --parallel
215-
ctest --preset release --output-on-failure -L unit
215+
ctest --preset release --output-on-failure
216216
env:
217217
CTEST_OUTPUT_ON_FAILURE: 1
218218
codecov:
@@ -235,7 +235,7 @@ jobs:
235235
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache
236236
cmake --build --preset coverage --parallel
237237
- name: Test
238-
run: ctest --preset coverage --output-on-failure -L unit
238+
run: ctest --preset coverage --output-on-failure
239239
env:
240240
CTEST_OUTPUT_ON_FAILURE: 1
241241
- name: Generate Coverage Data
@@ -248,29 +248,6 @@ jobs:
248248
files: coverage.xml
249249
disable_search: true
250250

251-
perf-tests:
252-
# Perf tests are intentionally not part of PR CI runtime budget.
253-
if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
254-
runs-on: ubuntu-latest
255-
steps:
256-
- uses: actions/checkout@v4
257-
with:
258-
submodules: true
259-
- name: Setup ccache
260-
uses: hendrikmuhs/ccache-action@v1.2
261-
with:
262-
key: ccache-${{ github.job }}
263-
- name: Build
264-
run: |
265-
cmake --preset release \
266-
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
267-
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache
268-
cmake --build --preset release --parallel
269-
- name: Run Perf Tests
270-
run: ctest --preset release --output-on-failure -L perf
271-
env:
272-
CTEST_OUTPUT_ON_FAILURE: 1
273-
274251
evaluate-model:
275252
runs-on: ubuntu-latest
276253
needs: [build-linux]

0 commit comments

Comments
 (0)