Skip to content

Commit c54ed5b

Browse files
authored
Address 'performance-avoid-endl' clang-tidy remarks (#250)
1 parent fc51112 commit c54ed5b

13 files changed

Lines changed: 90 additions & 96 deletions

File tree

.clang-tidy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ Checks: >
1919
-modernize-avoid-c-arrays,
2020
-modernize-pass-by-value,
2121
-performance-move-const-arg,
22-
-performance-avoid-endl,
2322
-readability-braces-around-statements,
2423
-readability-identifier-length,
2524
-readability-magic-numbers,

app/Converters/reader_weights_sample.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ int main() {
1212
std::string layer_type = layer_data["type"];
1313

1414
std::cout << "Layer " << layer_index << " (" << layer_type << ", "
15-
<< layer_name << "):" << std::endl;
15+
<< layer_name << "):" << '\n';
1616

1717
try {
1818
it_lab_ai::Tensor tensor = it_lab_ai::create_tensor_from_json(
1919
layer_data, it_lab_ai::Type::kFloat);
20-
// std::cout << tensor << std::endl;
20+
// std::cout << tensor << '\n';
2121
} catch (const std::exception& e) {
2222
std::cerr << "Error processing layer " << layer_name << ": " << e.what()
23-
<< std::endl;
23+
<< '\n';
2424
}
2525
}
2626

app/Converters/reader_weights_sample_onnx.cpp

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,8 @@ int main() {
66
std::string json_file = MODEL_PATH_GOOGLENET_ONNX;
77
it_lab_ai::json model_data = it_lab_ai::read_json(json_file);
88

9-
std::cout << "Model contains " << model_data.size()
10-
<< " layers:" << std::endl;
11-
std::cout << "--------------------------------------------------"
12-
<< std::endl;
9+
std::cout << "Model contains " << model_data.size() << " layers:" << '\n';
10+
std::cout << "--------------------------------------------------" << '\n';
1311

1412
for (const auto& layer_data : model_data) {
1513
int layer_index = layer_data["index"];
@@ -20,11 +18,11 @@ int main() {
2018
bool has_value = layer_data.contains("value");
2119

2220
std::cout << "Layer " << layer_index << ": " << layer_name << " ("
23-
<< layer_type << ")" << std::endl;
21+
<< layer_type << ")" << '\n';
2422

2523
if (layer_data.contains("attributes") &&
2624
!layer_data["attributes"].empty()) {
27-
std::cout << " Attributes:" << std::endl;
25+
std::cout << " Attributes:" << '\n';
2826
for (const auto& [key, value] : layer_data["attributes"].items()) {
2927
std::cout << " " << key << ": ";
3028
if (value.is_array()) {
@@ -42,16 +40,16 @@ int main() {
4240
} else if (value.is_string()) {
4341
std::cout << value.get<std::string>();
4442
}
45-
std::cout << std::endl;
43+
std::cout << '\n';
4644
}
4745
}
4846

4947
if (has_value) {
5048
try {
5149
float value = layer_data["value"].get<float>();
52-
std::cout << " Value: " << value << std::endl;
50+
std::cout << " Value: " << value << '\n';
5351
} catch (const std::exception& e) {
54-
std::cerr << " Error processing value: " << e.what() << std::endl;
52+
std::cerr << " Error processing value: " << e.what() << '\n';
5553
}
5654
}
5755

@@ -60,20 +58,19 @@ int main() {
6058
it_lab_ai::Tensor tensor = it_lab_ai::create_tensor_from_json(
6159
layer_data, it_lab_ai::Type::kFloat);
6260

63-
std::cout << " Weights shape: " << tensor.get_shape() << std::endl;
61+
std::cout << " Weights shape: " << tensor.get_shape() << '\n';
6462

6563
if (!tensor.get_bias().empty()) {
66-
std::cout << " Bias size: " << tensor.get_bias().size() << std::endl;
64+
std::cout << " Bias size: " << tensor.get_bias().size() << '\n';
6765
}
6866
} catch (const std::exception& e) {
69-
std::cerr << " Error processing weights: " << e.what() << std::endl;
67+
std::cerr << " Error processing weights: " << e.what() << '\n';
7068
}
7169
} else if (!has_value) {
72-
std::cout << " No weights or value" << std::endl;
70+
std::cout << " No weights or value" << '\n';
7371
}
7472

75-
std::cout << "--------------------------------------------------"
76-
<< std::endl;
73+
std::cout << "--------------------------------------------------" << '\n';
7774
}
7875

7976
return 0;

app/Graph/acc_check.cpp

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ int main(int argc, char* argv[]) {
3131
std::string json_path = model_paths[model_name];
3232
std::vector<int> input_shape = get_input_shape_from_json(json_path);
3333

34-
std::cout << std::endl;
34+
std::cout << '\n';
3535

3636
if (model_name == "alexnet_mnist") {
3737
std::vector<size_t> counts = {979, 1134, 1031, 1009, 981,
@@ -101,7 +101,7 @@ int main(int argc, char* argv[]) {
101101
double percentage =
102102
(static_cast<double>(stat) / static_cast<double>(sum + 10)) * 100;
103103
std::cout << "Stat: " << std::fixed << std::setprecision(2) << percentage
104-
<< "%" << std::endl;
104+
<< "%" << '\n';
105105
return 0;
106106
}
107107
std::vector<size_t> counts;
@@ -130,8 +130,7 @@ int main(int argc, char* argv[]) {
130130
}
131131

132132
if (total_images == 0) {
133-
std::cerr << "No images found in dataset path: " << dataset_path
134-
<< std::endl;
133+
std::cerr << "No images found in dataset path: " << dataset_path << '\n';
135134
return 1;
136135
}
137136

@@ -157,7 +156,7 @@ int main(int argc, char* argv[]) {
157156
cv::Mat image = cv::imread(entry.path().string());
158157
if (image.empty()) {
159158
std::cerr << "Failed to load image: " << entry.path().string()
160-
<< std::endl;
159+
<< '\n';
161160
continue;
162161
}
163162

@@ -237,18 +236,18 @@ int main(int argc, char* argv[]) {
237236
double final_accuracy_top5 =
238237
(static_cast<double>(correct_predictions_top5) / total_images) * 100;
239238

240-
std::cout << "\nFinal Results:" << std::endl;
241-
std::cout << "Model: " << model_name << std::endl;
242-
std::cout << "Dataset: " << dataset_path << std::endl;
243-
std::cout << "Total images: " << total_images << std::endl;
239+
std::cout << "\nFinal Results:" << '\n';
240+
std::cout << "Model: " << model_name << '\n';
241+
std::cout << "Dataset: " << dataset_path << '\n';
242+
std::cout << "Total images: " << total_images << '\n';
244243
std::cout << "Correct predictions (Top-1): " << correct_predictions_top1
245-
<< std::endl;
244+
<< '\n';
246245
std::cout << "Correct predictions (Top-5): " << correct_predictions_top5
247-
<< std::endl;
246+
<< '\n';
248247
std::cout << "Top-1 Accuracy: " << std::fixed << std::setprecision(2)
249-
<< final_accuracy_top1 << "%" << std::endl;
248+
<< final_accuracy_top1 << "%" << '\n';
250249
std::cout << "Top-5 Accuracy: " << std::fixed << std::setprecision(2)
251-
<< final_accuracy_top5 << "%" << std::endl;
250+
<< final_accuracy_top5 << "%" << '\n';
252251

253252
return 0;
254253
}

0 commit comments

Comments
 (0)