Pooling Layer OneDNN#263
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
+ Coverage 82.31% 82.98% +0.66%
==========================================
Files 49 51 +2
Lines 2630 2774 +144
Branches 1573 1662 +89
==========================================
+ Hits 2165 2302 +137
- Misses 226 228 +2
- Partials 239 244 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
allnes
reviewed
Feb 4, 2026
|
|
||
| if (data_type == Type::kFloat) { | ||
| const std::vector<float>& kernel_data = *kernel_.as<float>(); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
there was an error in the layer and it needed to be corrected
Member
There was a problem hiding this comment.
What I meant was that you added an extra line that does nothing.
aobolensk
approved these changes
Feb 6, 2026
allnes
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.