@@ -56,22 +56,26 @@ def test_full_installation_flow(self, mock_check_disk, mock_detect_host, mock_su
5656
5757 installer = AndroidInstaller (self .sdk_root )
5858
59- # Mock AVD creation
60- with patch .object (installer .avd , "create " ) as mock_avd_create :
61- mock_avd_create .return_value = True
59+ # Mock license acceptance to avoid actual sdkmanager call
60+ with patch .object (installer .sdk , "accept_licenses " ) as mock_accept :
61+ mock_accept .return_value = None
6262
63- result = installer .ensure (
64- api = 30 ,
65- target = "google_atd" ,
66- arch = "arm64-v8a" ,
67- ndk = NdkSpec (alias = "r26d" ),
68- create_avd_name = "test_avd" ,
69- dry_run = False ,
70- )
63+ # Mock AVD creation
64+ with patch .object (installer .avd , "create" ) as mock_avd_create :
65+ mock_avd_create .return_value = True
7166
72- assert isinstance (result , dict )
73- assert result ["sdk_root" ] == self .sdk_root
74- assert result ["avd_created" ] is True
67+ result = installer .ensure (
68+ api = 30 ,
69+ target = "google_atd" ,
70+ arch = "arm64-v8a" ,
71+ ndk = NdkSpec (alias = "r26d" ),
72+ create_avd_name = "test_avd" ,
73+ dry_run = False ,
74+ )
75+
76+ assert isinstance (result , dict )
77+ assert result ["sdk_root" ] == self .sdk_root
78+ assert result ["avd_created" ] is True
7579
7680 @patch ("subprocess.run" )
7781 @patch ("ovmobilebench.android.installer.detect.detect_host" )
@@ -288,44 +292,48 @@ def test_concurrent_component_installation(
288292
289293 installer = AndroidInstaller (self .sdk_root )
290294
291- # Mock multiple components needing installation
292- with patch .object (installer .sdk , "ensure_platform_tools" ) as mock_platform :
293- with patch .object (installer .sdk , "ensure_emulator" ) as mock_emulator :
294- with patch .object (installer .sdk , "ensure_build_tools" ) as mock_build :
295- with patch .object (installer .ndk , "ensure" ) as mock_ndk :
296- # Create cmdline tools and mock components first
297- self ._create_cmdline_tools ()
298-
299- # Create the directories that would be created
300- (self .sdk_root / "platforms" / "android-30" ).mkdir (parents = True )
301- (
302- self .sdk_root
303- / "system-images"
304- / "android-30"
305- / "google_atd"
306- / "arm64-v8a"
307- ).mkdir (parents = True )
308- (self .sdk_root / "cmake" / "3.22.1" ).mkdir (parents = True )
309-
310- # Set up return values
311- mock_platform .return_value = self .sdk_root / "platform-tools"
312- mock_emulator .return_value = self .sdk_root / "emulator"
313- mock_build .return_value = self .sdk_root / "build-tools" / "34.0.0"
314- mock_ndk .return_value = self .sdk_root / "ndk" / "26.3.11579264"
315-
316- installer .ensure (
317- api = 30 ,
318- target = "google_atd" ,
319- arch = "arm64-v8a" ,
320- ndk = NdkSpec (alias = "r26d" ),
321- install_build_tools = "34.0.0" ,
322- dry_run = False ,
323- )
324-
325- # All should be called
326- mock_platform .assert_called_once ()
327- mock_emulator .assert_called_once ()
328- mock_build .assert_called_once_with ("34.0.0" )
295+ # Mock license acceptance to avoid actual sdkmanager call
296+ with patch .object (installer .sdk , "accept_licenses" ) as mock_accept :
297+ mock_accept .return_value = None
298+
299+ # Mock multiple components needing installation
300+ with patch .object (installer .sdk , "ensure_platform_tools" ) as mock_platform :
301+ with patch .object (installer .sdk , "ensure_emulator" ) as mock_emulator :
302+ with patch .object (installer .sdk , "ensure_build_tools" ) as mock_build :
303+ with patch .object (installer .ndk , "ensure" ) as mock_ndk :
304+ # Create cmdline tools and mock components first
305+ self ._create_cmdline_tools ()
306+
307+ # Create the directories that would be created
308+ (self .sdk_root / "platforms" / "android-30" ).mkdir (parents = True )
309+ (
310+ self .sdk_root
311+ / "system-images"
312+ / "android-30"
313+ / "google_atd"
314+ / "arm64-v8a"
315+ ).mkdir (parents = True )
316+ (self .sdk_root / "cmake" / "3.22.1" ).mkdir (parents = True )
317+
318+ # Set up return values
319+ mock_platform .return_value = self .sdk_root / "platform-tools"
320+ mock_emulator .return_value = self .sdk_root / "emulator"
321+ mock_build .return_value = self .sdk_root / "build-tools" / "34.0.0"
322+ mock_ndk .return_value = self .sdk_root / "ndk" / "26.3.11579264"
323+
324+ installer .ensure (
325+ api = 30 ,
326+ target = "google_atd" ,
327+ arch = "arm64-v8a" ,
328+ ndk = NdkSpec (alias = "r26d" ),
329+ install_build_tools = "34.0.0" ,
330+ dry_run = False ,
331+ )
332+
333+ # All should be called
334+ mock_platform .assert_called_once ()
335+ mock_emulator .assert_called_once ()
336+ mock_build .assert_called_once_with ("34.0.0" )
329337
330338 # Helper methods to create mock components
331339
0 commit comments