Refactor/cloud architecture#98
Merged
allnes merged 3 commits intoMay 18, 2026
Merged
Conversation
- Introduced DomainFile data class in :domain module to encapsulate local file paths without exposing platform-specific java.io.File. - Updated CloudDataSource interface to accept DomainFile for media upload and download operations. - Refactored FirebaseCloudDataSource to map DomainFile back to java.io.File internally, maintaining system isolation. - Adjusted SyncManagerImpl to wrap raw file paths into DomainFile before interacting with the cloud data source.
- Updated test suites to comply with the new DomainFile contract. - Refactored downloadMedia success test to match any File type instead of a strict mocked instance, avoiding reference mismatch during local instantiation. - Updated SyncManagerImplTest verifications to properly evaluate DomainFile.path instead of File.absolutePath. - Cleaned up generic any() matchers to prevent MockK runtime ClassCastExceptions.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
waiafur
approved these changes
May 18, 2026
lyzlovazlata
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.