perf: improve build cache reuse and PR-safe pushes#15
Merged
Conversation
Signed-off-by: Jonathan Beri <jmberi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves CI build speed and cache hit rates, and fixes the workflow so images are not pushed on pull request runs.
Changes
CI (publish.yml)
cache-from/cache-to(GitHub Actions cache) with per-image scopes forbase,arch,llvm, andposixjobs./zephyr-base,./zephyr,./zephyr-posix) to reduce context upload size and cache churnmainbranch pushes, not on pull requestsDockerfiles
# syntax=docker/dockerfile:1.7to all three images to enable BuildKit cache mount syntax--mount=type=cachefor apt and pip inzephyr-base/Dockerfile, keeping package indexes and pip wheels cached across rebuilds without bloating image layerszephyr-base/Dockerfileso aZEPHYR_SDK_VERSIONbump only invalidates the SDK layer, not Pythonapt-get update+ install/remove cycles inzephyr/Dockerfileandzephyr-posix/Dockerfile(setup.sh does not require wget/xz-utils to be freshly installed by the derived image — they are available from the base)ZEPHYR_SDK_VERSIONdefault inzephyr-posix/Dockerfileto1.0.0.dockerignore
.git,.github,README.md, andLICENSEfrom the build contextTesting
All three images built and verified locally:
zephyr:base-1.0.0SDK(arm64)zephyr:arm-1.0.0SDK(arm64)zephyr:posix-1.0.0SDK(amd64 —gcc-multilibis amd64-only, matches CI)