Commit 8d92537
authored
fix: OgmaWrapper inherit from AbsEncoder (#4670)
OgmaWrapper was declared as a bare class, so isinstance(model, EncoderProtocol)
returns False and RetrievalEvaluator rejects it with TypeError. Inheriting from
AbsEncoder picks up the default similarity / similarity_pairwise implementations
driven by ModelMeta.similarity_fn_name (already set to COSINE for all Ogma
models). No change to encoding behaviour.
Reported by @Samoed on embeddings-benchmark/results#525.1 parent 33f9ea4 commit 8d92537
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | | - | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
0 commit comments