Skip to content

Commit 8d92537

Browse files
fix: OgmaWrapper inherit from AbsEncoder (#4670)
OgmaWrapper was declared as a bare class, so isinstance(model, EncoderProtocol) returns False and RetrievalEvaluator rejects it with TypeError. Inheriting from AbsEncoder picks up the default similarity / similarity_pairwise implementations driven by ModelMeta.similarity_fn_name (already set to COSINE for all Ogma models). No change to encoding behaviour. Reported by @Samoed on embeddings-benchmark/results#525.
1 parent 33f9ea4 commit 8d92537

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

mteb/models/model_implementations/axiotic_models.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import numpy as np
66
import torch
77

8+
from mteb.models.abs_encoder import AbsEncoder
89
from mteb.models.model_meta import ModelMeta, ScoringFunction
910

1011
if TYPE_CHECKING:
@@ -23,7 +24,7 @@
2324
)
2425

2526

26-
class OgmaWrapper:
27+
class OgmaWrapper(AbsEncoder):
2728
"""MTEB wrapper for Axiotic Ogma embedding models."""
2829

2930
def __init__(

0 commit comments

Comments
 (0)