Skip to content

Commit eb42ec7

Browse files
fix: remove button from Gradio event handler inputs in benchmark selector (#4553)
* fix: remove button from Gradio event handler inputs in benchmark selector `_update_value` and `_update_variant` used gr.Button as an input to read its label, but Gradio doesn't reliably pass button values causing "didn't receive enough input values" errors (~340 occurrences in logs). Seems like label is already in scope so no input is needed. Tested locally and everything worked fine (and couldn't get it to re-appear), but I am not 100% sure on this change. * Update mteb/leaderboard/benchmark_selector.py Co-authored-by: Roman Solomatin <samoed.roman@gmail.com> --------- Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
1 parent 227c7b4 commit eb42ec7

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

mteb/leaderboard/benchmark_selector.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ def _create_button(
3434
**kwargs,
3535
)
3636

37-
def _update_variant(state: str, label: str) -> gr.Button:
37+
def _update_variant(state: str) -> gr.Button:
3838
if state == label_to_value[label]:
3939
return gr.Button(variant="primary")
4040
else:
4141
return gr.Button(variant="secondary")
4242

43-
def _update_value(label: str) -> str:
43+
def _update_value() -> str:
4444
return label_to_value[label]
4545

46-
state.change(_update_variant, inputs=[state, button], outputs=[button])
47-
button.click(_update_value, inputs=[button], outputs=[state])
46+
state.change(_update_variant, inputs=[state], outputs=[button])
47+
button.click(_update_value, outputs=[state])
4848
return button
4949

5050

0 commit comments

Comments
 (0)