fix: remove button from Gradio event handler inputs in benchmark selector#4553
Merged
KennethEnevoldsen merged 2 commits intofix-get_tasks_failurefrom Apr 30, 2026
Merged
fix: remove button from Gradio event handler inputs in benchmark selector#4553KennethEnevoldsen merged 2 commits intofix-get_tasks_failurefrom
KennethEnevoldsen merged 2 commits intofix-get_tasks_failurefrom
Conversation
…ctor `_update_value` and `_update_variant` used gr.Button as an input to read its label, but Gradio doesn't reliably pass button values causing "didn't receive enough input values" errors (~340 occurrences in logs). Seems like label is already in scope so no input is needed. Tested locally and everything worked fine (and couldn't get it to re-appear), but I am not 100% sure on this change.
Samoed
approved these changes
Apr 29, 2026
Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
KennethEnevoldsen
added a commit
that referenced
this pull request
Apr 30, 2026
* fix: Only log missing subset once
Missing subset appears more than 14k times in the leaderboard. It is probably enough just to raise this warning once.
* fix: Allow `get_tasks` to filter out a tasks
Currently:
```
tasks = mteb.get_tasks(["AILAStatutes"], languages=["dan"])
```
would raise an ValueError, now it will raise a warning, but only once.
Currently in the leadboard this produces the following error:
```
File "/mteb/mteb/abstasks/abstask.py", line 535, in filter_languages
raise ValueError(
ValueError: No subsets were found for AILAStatutes with filters: language code ['dan', 'swe', 'nno', 'nob'], script None, hf subsets None.
```
* format
* fix: remove button from Gradio event handler inputs in benchmark selector (#4553)
* fix: remove button from Gradio event handler inputs in benchmark selector
`_update_value` and `_update_variant` used gr.Button as an input to read
its label, but Gradio doesn't reliably pass button values causing
"didn't receive enough input values" errors (~340 occurrences in logs).
Seems like label is already in scope so no input is needed. Tested locally and everything worked fine (and couldn't get it to re-appear), but I am not 100% sure on this change.
* Update mteb/leaderboard/benchmark_selector.py
Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
---------
Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
---------
Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_update_valueand_update_variantused gr.Button as an input to read its label, but Gradio doesn't reliably pass button values causing "didn't receive enough input values" errors (~340 occurrences in logs).Seems like label is already in scope so no input is needed. Tested locally and everything worked fine (and couldn't get it to re-appear), but I am not 100% sure on this change.
If you add a model or a dataset, please add the corresponding checklist: