Fix serving a file without an extension

Author: krisselden

lib/utils/response-header.js

@@ -34,7 +34,8 @@ const setFileContentResponseHeaders = (request, response, options) => {
   response.setHeader('Content-Length', options.fileSize);
   response.setHeader(
     'Content-Type',
-    mime.contentType(path.extname(options.filename))
+    mime.contentType(path.basename(options.filename)) ||
+      'application/octet-stream'
   );
 };
 

test/fixtures/basic-file/noext

@@ -0,0 +1 @@
+content

test/serve-asset-middleware-test.js

@@ -40,6 +40,37 @@ describe('serve-middleware', function() {
         });
     });
 
+    it('serves the given file without an extension', function() {
+      const watcher = RSVP.Promise.resolve({
+        directory: fixture('basic-file')
+      });
+
+      const middleware = watcherMiddleware(watcher, {
+        autoIndex: false
+      });
+
+      server = new TestHTTPServer(middleware);
+      server.addMiddleware(serveAssetMiddleware);
+
+      return server
+        .start()
+        .then(info => {
+          return server.request('/noext', {
+            info: info,
+            resolveWithFullResponse: true
+          });
+        })
+        .then(res => {
+          expect(res.headers['content-type']).to.equal(
+            'application/octet-stream'
+          );
+          expect(res.headers['content-length']).to.equal(
+            'content'.length.toString()
+          );
+          expect(res.body).to.equal('content');
+        });
+    });
+
     it('serves the content-type according to the header', function() {
       const watcher = RSVP.Promise.resolve({
         directory: fixture('wasm-file')