Skip to content

Commit 61d13d7

Browse files
Add comments for filename check
1 parent 49aca1f commit 61d13d7

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

lib/utils/filename-normaliser.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,12 @@ const { existsSync } = require('fs');
66

77
const pkg = require(findup.sync('package.json'));
88

9-
const normaliseFileName = (fileName = '') => {
10-
// not a valid file name
9+
const normaliseFileName = function(fileName = '') {
10+
// check for invalid file paths
11+
// for example,
12+
// path.basename('myfile') will be myfile, doesn't need normalisation as this is probably
13+
// not a template file
14+
// path.basename('templates/myfile') will not be equal to fileName
1115
if (path.basename(fileName) === fileName) {
1216
return null;
1317
}
@@ -42,7 +46,7 @@ const normaliseFileName = (fileName = '') => {
4246
return path.join(...fileNameElements);
4347
};
4448

45-
const getNormalisedFileName = (fileName, line = 1, column = 1) => {
49+
const getNormalisedFileName = function(fileName, line = 1, column = 1) {
4650
let normalisedFileName = normaliseFileName(fileName);
4751
if (existsSync(normalisedFileName)) {
4852
return `${normalisedFileName}:${line}:${column}`;

0 commit comments

Comments
 (0)