Skip to content

Commit d5445cc

Browse files
authored
Merge pull request #58 from rwjblue/update-to-3-4
Update to ember-cli@3.4 blueprint.
2 parents 7f8ffdc + 34afb44 commit d5445cc

23 files changed

Lines changed: 1437 additions & 1050 deletions

.eslintignore

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# unconventional js
2+
/blueprints/*/files/
3+
/vendor/
4+
5+
# compiled output
6+
/dist/
7+
/tmp/
8+
9+
# dependencies
10+
/bower_components/
11+
12+
# misc
13+
/coverage/
14+
15+
# ember-try
16+
/.node_modules.ember-try/
17+
/bower.json.ember-try
18+
/package.json.ember-try

.eslintrc.js

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,19 @@ module.exports = {
2020
// node files
2121
{
2222
files: [
23+
'.template-lintrc.js',
24+
'ember-cli-build.js',
25+
'generate-deprecations-tree.js',
2326
'index.js',
2427
'testem.js',
25-
'ember-cli-build.js',
28+
'blueprints/*/index.js',
2629
'config/**/*.js',
2730
'tests/dummy/config/**/*.js'
2831
],
2932
excludedFiles: [
30-
'app/**',
3133
'addon/**',
34+
'addon-test-support/**',
35+
'app/**',
3236
'tests/dummy/app/**'
3337
],
3438
parserOptions: {
@@ -41,18 +45,8 @@ module.exports = {
4145
},
4246
plugins: ['node'],
4347
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
44-
// add your custom rules and overrides for node files here
48+
'ember/new-module-imports': false,
4549
})
46-
},
47-
48-
// test files
49-
{
50-
files: ['tests/**/*.js'],
51-
excludedFiles: ['tests/dummy/**/*.js'],
52-
env: {
53-
embertest: true
54-
},
55-
rules: {}
5650
}
5751
]
5852
};

.gitignore

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
# See https://help.github.com/ignore-files/ for more about ignoring files.
22

33
# compiled output
4-
/dist
5-
/tmp
4+
/dist/
5+
/tmp/
66

77
# dependencies
8-
/node_modules
9-
/bower_components
8+
/bower_components/
9+
/node_modules/
1010

1111
# misc
1212
/.sass-cache
1313
/connect.lock
14-
/coverage/*
14+
/coverage/
1515
/libpeerconnection.log
16-
npm-debug.log*
17-
yarn-error.log
18-
testem.log
16+
/npm-debug.log*
17+
/testem.log
18+
/yarn-error.log
1919

2020
# ember-try
21-
.node_modules.ember-try/
22-
bower.json.ember-try
23-
package.json.ember-try
21+
/.node_modules.ember-try/
22+
/bower.json.ember-try
23+
/package.json.ember-try

.npmignore

Lines changed: 25 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,28 @@
1-
/bower_components
1+
# compiled output
2+
/dist/
3+
/tmp/
4+
5+
# dependencies
6+
/bower_components/
7+
8+
# misc
9+
/.bowerrc
10+
/.editorconfig
11+
/.ember-cli
12+
/.eslintignore
13+
/.eslintrc.js
14+
/.gitignore
15+
/.watchmanconfig
16+
/.travis.yml
17+
/bower.json
218
/config/ember-try.js
3-
/dist
4-
/tests
5-
/tmp
6-
**/.gitkeep
7-
.bowerrc
8-
.editorconfig
9-
.ember-cli
10-
.eslintrc.js
11-
.gitignore
12-
.watchmanconfig
13-
.travis.yml
14-
bower.json
15-
ember-cli-build.js
16-
testem.js
19+
/ember-cli-build.js
20+
/testem.js
21+
/tests/
22+
/yarn.lock
23+
.gitkeep
1724

1825
# ember-try
19-
.node_modules.ember-try/
20-
bower.json.ember-try
21-
package.json.ember-try
26+
/.node_modules.ember-try/
27+
/bower.json.ember-try
28+
/package.json.ember-try

.template-lintrc.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
extends: 'recommended'
5+
};

.travis.yml

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,29 +19,36 @@ env:
1919
global:
2020
# See https://git.io/vdao3 for details.
2121
- JOBS=1
22-
matrix:
23-
# we recommend new addons test the current and previous LTS
24-
# as well as latest stable release (bonus points to beta/canary)
25-
- EMBER_TRY_SCENARIO=ember-lts-2.12
26-
- EMBER_TRY_SCENARIO=ember-lts-2.16
27-
- EMBER_TRY_SCENARIO=ember-release
28-
- EMBER_TRY_SCENARIO=ember-beta
29-
- EMBER_TRY_SCENARIO=ember-canary
30-
- EMBER_TRY_SCENARIO=ember-default
31-
32-
matrix:
33-
fast_finish: true
22+
23+
jobs:
24+
fail_fast: true
3425
allow_failures:
3526
- env: EMBER_TRY_SCENARIO=ember-canary
27+
28+
include:
29+
# runs linting and tests with current locked deps
30+
31+
- stage: "Tests"
32+
name: "Tests"
33+
script:
34+
- npm run lint:hbs
35+
- npm run lint:js
36+
- npm test
37+
38+
# we recommend new addons test the current and previous LTS
39+
# as well as latest stable release (bonus points to beta/canary)
40+
- stage: "Additional Tests"
41+
env: EMBER_TRY_SCENARIO=ember-lts-2.16
42+
- env: EMBER_TRY_SCENARIO=ember-lts-2.18
43+
- env: EMBER_TRY_SCENARIO=ember-release
3644
- env: EMBER_TRY_SCENARIO=ember-beta
45+
- env: EMBER_TRY_SCENARIO=ember-canary
46+
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
3747

3848
before_install:
3949
- npm config set spin false
4050
- npm install -g npm@4
4151
- npm --version
4252

4353
script:
44-
- npm run lint:js
45-
# Usually, it's ok to finish the test scenario without reverting
46-
# to the addon's original dependency state, skipping "cleanup".
47-
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup
54+
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO

README.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ An addon geared towards making Ember upgrades easier by allowing you to work thr
44

55
[![Build Status](https://travis-ci.org/mixonic/ember-cli-deprecation-workflow.svg)](https://travis-ci.org/mixonic/ember-cli-deprecation-workflow)
66

7-
This README outlines the details of collaborating on this Ember addon.
7+
[Short description of the addon.]
88

99
## History
1010

@@ -99,8 +99,9 @@ Details on contributing to the addon itself (not required for normal usage).
9999

100100
### Running
101101

102-
* `ember serve`
103-
* Visit your app at [http://localhost:4200](http://localhost:4200).
102+
* `npm run lint:hbs`
103+
* `npm run lint:js`
104+
* `npm run lint:js -- --fix`
104105

105106
### Running Tests
106107

@@ -109,6 +110,12 @@ Details on contributing to the addon itself (not required for normal usage).
109110

110111
### Building
111112

112-
* `ember build`
113+
* `ember serve`
114+
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
113115

114116
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
117+
118+
License
119+
------------------------------------------------------------------------------
120+
121+
This project is licensed under the [MIT License](LICENSE.md).

0 commit comments

Comments
 (0)