Not compatible with compat-less vite app

[NullVoxPopuli]

To get things working again, I have to change my import from

import setupDeprecationWorkflow from 'ember-cli-deprecation-workflow'

to

import setupDeprecationWorkflow from 'ember-cli-deprecation-workflow/addon/index'

which is fine, but a bit annoying

[NullVoxPopuli]

This came up in vitejs/vite#19564

[simonihmig]

'ember-cli-deprecation-workflow/addon/index'

this is not something the package exposes really, just a side effect of bypassing the v1 build, right? Which is not even guaranteed to be correct, as v1 addons could do random things.

Isn't the fix here to just migrate to v2 and everything will just work? We did discuss this recently in the team meeting, the only gap would be the existing support for deprecations in vendor.js, and we might be able to also support that if needed. Been in touch with @mansona on this...

[NullVoxPopuli]

this is not something the package exposes really, just a side effect of bypassing the v1 build, right?

Ya, outside of ember (like when you disable or remove emberCompat), you can (attempt to) import every file in a v1 addon -- everything is exposed because v1 addons are not using package.json#exports -- but as you point out, these are kind of all private implementation details.

Isn't the fix here to just migrate to v2 and everything will just work?

ye!

the existing support for deprecations in vendor.js, and we might be able to also support that if needed

vendor.js doesn't exist in vite apps, ya? so I think we've accidentally solved that problem by evasion somehow! 🎉