Merge pull request #1449 from ember-cli/nvp/nvp/split-acceptance-tests-for-easier-retries

Spit node-tests in to parallel jobs for easier retries (we have a very short testem timeout)

Author: NullVoxPopuli

.github/workflows/ci.yml

@@ -1,4 +1,4 @@
-name: CI Build
+name: CI
 
 on:
   push:
@@ -11,6 +11,23 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  setup:
+    name: 'Setup'
+    runs-on: ubuntu-latest
+    timeout-minutes: 2
+    outputs:
+      matrix: ${{ steps.set-matrix.outputs.matrix }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          # This version is different, because we want newer node features
+          # so that we can skip pnpm install for this job
+          node-version: 24
+      - id: set-matrix
+        run: |
+          echo "matrix=$(node ./node-tests/list.mjs)" >> $GITHUB_OUTPUT
+
   lint:
     name: Lints
     runs-on: ubuntu-latest
@@ -49,9 +66,13 @@ jobs:
         working-directory: ${{ matrix.app.dir }}
 
   test-node:
-    name: Node Tests
+    name: "Mocha | ${{ matrix.name }}"
+    needs: ["setup"]
     runs-on: ubuntu-latest
     timeout-minutes: 30
+    strategy:
+      fail-fast: false
+      matrix: ${{fromJson(needs.setup.outputs.matrix)}}
 
     steps:
       - uses: actions/checkout@v4
@@ -61,7 +82,7 @@ jobs:
           node-version: 18
           cache: 'pnpm'
       - run: pnpm install
-      - run: pnpm test:node
+      - run: ${{ matrix.command }}
 
   floating-dependencies:
     name: "Floating Dependencies"

node-tests/list.mjs

@@ -0,0 +1,47 @@
+/**
+ * This file is used by CI to list all the test files we have to generate a matrix to run.
+ * Since our node-tests dirty the working directory, we don't want to have different test files stepping on each other.
+ *
+ * Additionally, this allows us to run each test file in parallel with the other test files.
+ *
+ * The code here was copied from https://github.com/embroider-build/try/blob/main/cli.js
+ * (ish)
+ */
+import assert from "node:assert";
+// We run this file on node 24
+// eslint-disable-next-line n/no-unsupported-features/node-builtins
+import { glob } from "node:fs/promises";
+
+let files = [
+  {
+    name: "Unit",
+    command: "pnpm mocha 'node-tests/unit/**/*-test.js'",
+  },
+];
+
+for await (const entry of glob(
+  "node-tests/acceptance/**/*-test.{js,ts,mjs,cjs,mts,cts}",
+)) {
+  let name = entry.replace("node-tests/acceptance/", "");
+  files.push({
+    name,
+    include: {
+      name,
+      command: `pnpm mocha ${entry}`,
+    },
+  });
+}
+
+assert(
+  files.length > 0,
+  `There were no found test files -- this is unexpected`,
+);
+
+process.stdout.write(
+  JSON.stringify({
+    name: files.map((s) => s.name),
+    // always include an empty env by default, so that it's convenient to pass
+    // `${{ matrix.env }}` in github actions
+    include: files.map((s) => ({ env: {}, ...s.include })),
+  }),
+);