From e946286ac0711cf8dbccee1ab4fd0e73d01a66e1 Mon Sep 17 00:00:00 2001 From: aalasolutions <110997371+aalasolutions@users.noreply.github.com> Date: Mon, 19 Jun 2023 20:50:56 +0500 Subject: [PATCH 1/2] Update page-title.js fix: Do not update the title if it is empty --- addon/src/services/page-title.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/addon/src/services/page-title.js b/addon/src/services/page-title.js index 204578a3..0c74c156 100644 --- a/addon/src/services/page-title.js +++ b/addon/src/services/page-title.js @@ -204,6 +204,11 @@ export default class PageTitleService extends Service { _updateTitle() { const toBeTitle = this.toString(); + if (!toBeTitle) { + // Do not set the title to empty string + return; + } + if (isFastBoot) { this.updateFastbootTitle(toBeTitle); } else { From 497459a5a748bff3e5d3fb1c0af029e16cec9be2 Mon Sep 17 00:00:00 2001 From: aalasolutions <110997371+aalasolutions@users.noreply.github.com> Date: Tue, 20 Jun 2023 19:15:14 +0500 Subject: [PATCH 2/2] Lint extra spaces removed --- addon/src/services/page-title.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addon/src/services/page-title.js b/addon/src/services/page-title.js index 0c74c156..3ef33045 100644 --- a/addon/src/services/page-title.js +++ b/addon/src/services/page-title.js @@ -208,7 +208,7 @@ export default class PageTitleService extends Service { // Do not set the title to empty string return; } - + if (isFastBoot) { this.updateFastbootTitle(toBeTitle); } else {