Merged
Conversation
NullVoxPopuli
force-pushed
the
nvp/update-typescript
branch
from
6895b1c to
ef661cb
Compare
NullVoxPopuli
force-pushed
the
nvp/update-typescript
branch
from
ef661cb to
32adf6f
Compare
Contributor
Author
|
I don't care to fix TS 6 / next atm, in this PR, because the error is about missing glint environment -- and that goes away with Glint 2 the test failures will be resolved in PRs after #305 -- since they're about newer ember-source the 5.12 failure is just a failure on cleanup, which I'll PR separately |
Open
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for Glint 2, we need a more modern TS and TS configs -- you'll notice that the TS test matrix shifted in CI -- this does not mean that ember-page-title won't work with older TSes, but it does mean that I don't want to figure out how to test broad TS support, since they require different tsconfigs