Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
b376ae6
Apply the vite codemod to both apps
NullVoxPopuli Apr 17, 2026
7524929
lint:fix, remove v1 addons. lint didn't pass because our ember-cli-bu…
NullVoxPopuli Apr 17, 2026
9c2523e
Remove ember-cli and ember-cli* dependencies
NullVoxPopuli Apr 17, 2026
89d5b62
Add ember-strict-application-resolver (polyfill) and vite-ember-ssr
NullVoxPopuli Apr 17, 2026
b88fafa
Eliminate node-based config/environment
NullVoxPopuli Apr 17, 2026
06eafc9
Update test-helper(s) to use enterTestMode
NullVoxPopuli Apr 17, 2026
fd16481
@embroider/try
NullVoxPopuli Apr 17, 2026
f360b51
Fix dependency order in CI
NullVoxPopuli Apr 18, 2026
263390f
switch to testem from ember-cli
NullVoxPopuli Apr 18, 2026
ac517af
Add cwd: dist to testem configs
NullVoxPopuli Apr 18, 2026
c643ccf
Force add .env.development
NullVoxPopuli Apr 18, 2026
8aa5996
Remove classicEmberSupport from vite configs
NullVoxPopuli Apr 18, 2026
2ac68c2
Remove embroider compat from the babel configs
NullVoxPopuli Apr 18, 2026
2fb4772
Fix babel configs
NullVoxPopuli Apr 18, 2026
eb66ab3
Remove ember-load-initializers
NullVoxPopuli Apr 18, 2026
485b7ac
Setup the strict resolver
NullVoxPopuli Apr 18, 2026
c181c70
Remove ember-resolver
NullVoxPopuli Apr 18, 2026
87ea18b
Rename testem files to cjs
NullVoxPopuli Apr 18, 2026
b09bc03
Update testem configs to handle CI_BROWSER
NullVoxPopuli Apr 18, 2026
f945468
Remove all content-for and virtual script/link references
NullVoxPopuli Apr 18, 2026
bf8d744
Fix router import
NullVoxPopuli Apr 18, 2026
4e888c4
Docs tests now run and pass
NullVoxPopuli Apr 18, 2026
dca249b
Delete fastboot tests, because they are irrelevant now
NullVoxPopuli Apr 18, 2026
92fd155
test-app tests pass now
NullVoxPopuli Apr 18, 2026
857ebee
Fix CI
NullVoxPopuli Apr 18, 2026
becfbca
Had to update eslint because type=module, and eslint 8 is just bad
NullVoxPopuli Apr 18, 2026
303bb39
Update ci for try
NullVoxPopuli Apr 18, 2026
045f523
Update ci for try
NullVoxPopuli Apr 18, 2026
98e40bf
Restore styles for docs
NullVoxPopuli Apr 18, 2026
ee22a86
Add SSG for the docs app -- ready to deploy
NullVoxPopuli Apr 18, 2026
a5b810e
Set allow-failure on every try scenario
NullVoxPopuli Apr 18, 2026
c2d24e8
Merge pull request #318 from NullVoxPopuli-ai-agent/fix/try-scenarios…
NullVoxPopuli Apr 18, 2026
cc1cb2f
Enable classicEmberSupport() for compat-build scenarios
NullVoxPopuli Apr 18, 2026
3f87e2b
Write ember-cli-build as .cjs in compat scenarios
NullVoxPopuli Apr 19, 2026
35ccbed
Update vite.config.mjs
NullVoxPopuli Apr 19, 2026
1512bf9
Merge pull request #319 from NullVoxPopuli-ai-agent/fix/compat-build-…
NullVoxPopuli Apr 19, 2026
944fd43
Conditionally import legacy-inspector-support per ember-source version
NullVoxPopuli Apr 19, 2026
98674b0
Merge pull request #320 from NullVoxPopuli-ai-agent/fix/inspector-sup…
NullVoxPopuli Apr 19, 2026
4e7cdc0
Bump @ember/test-helpers to ^4 in ember4 try scenarios
NullVoxPopuli Apr 19, 2026
e965739
Merge pull request #321 from NullVoxPopuli-ai-agent/fix/bump-test-hel…
NullVoxPopuli Apr 19, 2026
0691d3f
Make ember-lts-4.12 compat scenario runnable
NullVoxPopuli Apr 19, 2026
3d044e1
Polyfill @ember/owner imports for min-supported scenario
NullVoxPopuli Apr 19, 2026
f231990
Merge pull request #322 from NullVoxPopuli-ai-agent/fix/ember-lts-4-1…
NullVoxPopuli Apr 19, 2026
62fbb6c
Merge pull request #323 from NullVoxPopuli-ai-agent/fix/min-supported…
NullVoxPopuli Apr 19, 2026
81ef341
Don't run @ember/owner polyfill on ember-source itself
NullVoxPopuli Apr 19, 2026
2ca69f6
Merge pull request #324 from NullVoxPopuli-ai-agent/fix/ember-owner-p…
NullVoxPopuli Apr 19, 2026
8450eae
finish vite-ember-ssr setup
evoactivity Apr 20, 2026
14ca72f
remove ssr noExternal configuration from vite config
evoactivity Apr 20, 2026
24b2229
Cleanup
NullVoxPopuli Apr 22, 2026
19410ec
highlight is a js file
evoactivity Apr 22, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 89 additions & 33 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,69 @@ on:
pull_request: {}

jobs:
build_matrix:
name: "Build Matrix"
runs-on: ubuntu-latest
timeout-minutes: 5
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v6
with:
node-version-file: package.json
cache: pnpm
- id: set-matrix
run: |
echo "matrix=$(pnpm dlx @embroider/try list)" >> $GITHUB_OUTPUT
working-directory: test-app

# We do this so we ensure that we test with the same
# assets each time.
# (And don't have build or use prepare each phase of ci,
# (saving water, hopefully))
build_addon:
name: "Build Addon"
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: wyvox/action-setup-pnpm@v3
- run: pnpm build
- uses: actions/upload-artifact@v4
with:
name: dist
path: |
addon/dist/
addon/declarations/

lint:
name: Lint
runs-on: ubuntu-latest
timeout-minutes: 20
needs: [build_addon]
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: wyvox/action-setup-pnpm@v3
- run: pnpm build
- uses: actions/download-artifact@v4
with:
name: dist
path: addon
- name: Lint
run: pnpm lint

test:
name: Tests
runs-on: ${{ matrix.os }}
timeout-minutes: 20
needs: lint
needs: [build_addon]

strategy:
matrix:
Expand All @@ -37,9 +82,14 @@ jobs:
with:
fetch-depth: 1
- uses: wyvox/action-setup-pnpm@v3
- run: pnpm build
- uses: actions/download-artifact@v4
with:
name: dist
path: addon
- name: Test
run: pnpm test:ember --launch ${{ matrix.browser }}
run: pnpm test:ember
env:
CI_BROWSER: ${{ matrix.browser }}
working-directory: test-app

floating-dependencies:
Expand All @@ -60,13 +110,19 @@ jobs:
- uses: wyvox/action-setup-pnpm@v3
with:
pnpm-args: "--no-lockfile"
- run: pnpm build
- uses: actions/download-artifact@v4
with:
name: dist
path: addon
- name: Test
run: pnpm test:ember --launch ${{ matrix.browser }}
run: pnpm test:ember
env:
CI_BROWSER: ${{ matrix.browser }}
working-directory: test-app

typecheck:
name: "${{ matrix.typescript-scenario }}"
needs: [test]
runs-on: ubuntu-latest
timeout-minutes: 2
continue-on-error: true
Expand All @@ -83,8 +139,10 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: wyvox/action-setup-pnpm@v3
- run: pnpm build
- run: pnpm i -f # just in case
- uses: actions/download-artifact@v4
with:
name: dist
path: addon
- name: "test-types : ${{ matrix.typescript-scenario }}"
working-directory: ./test-types
run: "pnpm add --save-dev ${{ matrix.typescript-scenario}}"
Expand All @@ -107,39 +165,35 @@ jobs:
pnpm ember-tsc

try-scenarios:
name: Tests - ${{ matrix.ember-try-scenario }}
runs-on: ubuntu-latest
timeout-minutes: 20
continue-on-error: ${{ matrix.allow-failure }}
needs: test

needs: [test, build_matrix]
strategy:
fail-fast: false
matrix:
ember-try-scenario: [
minimum-supported-4-2,
ember-lts-4.4,
ember-lts-4.12,
ember-lts-5.12,
ember-release,
ember-beta
ember-canary,
]
allow-failure: [false]
include:
- ember-try-scenario: ember-canary
allow-failure: true
matrix: ${{fromJson(needs.build_matrix.outputs.matrix)}}

name: "${{ matrix.name }}"

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: wyvox/action-setup-pnpm@v3
- run: pnpm build
- name: Test
env:
EMBER_TRY_SCENARIO: ${{ matrix.ember-try-scenario }}
run: node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v6
with:
node-version-file: package.json
cache: pnpm
- run: pnpm dlx @embroider/try apply ${{ matrix.name }}
working-directory: test-app
- run: pnpm install --no-lockfile --ignore-scripts
- uses: actions/download-artifact@v4
with:
name: dist
path: addon

- run: pnpm test:ember
env: ${{ matrix.env }}
working-directory: test-app

docs:
Expand All @@ -152,8 +206,10 @@ jobs:
with:
fetch-depth: 1
- uses: wyvox/action-setup-pnpm@v3
- run: pnpm build

- uses: actions/download-artifact@v4
with:
name: dist
path: addon
- name: Test
run: pnpm test:ember
working-directory: docs
8 changes: 1 addition & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,9 @@ Inside any of the packages you can run:
- `pnpm lint`
- `pnpm lint:fix`

## Running tests

- `cd test-app && ember test` – Runs the test suite on the current Ember version
- `cd test-app && ember test --server` – Runs the test suite in "watch mode"
- `cd test-app & ember try:each` – Runs the test suite against multiple Ember versions

## Running the test application

- `cd test-app && ember serve`
- `cd test-app && pnpm vite`
- Visit the test application at [http://localhost:4200](http://localhost:4200).

For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
22 changes: 0 additions & 22 deletions addon/.eslintignore

This file was deleted.

56 changes: 0 additions & 56 deletions addon/.eslintrc.cjs

This file was deleted.

File renamed without changes.
Loading
Loading