feat(require-input-label): add checkLabelFor option for sibling <label for> verification

Opt-in (default false). When enabled, an input with only a static `id`
(no aria-label/labelledby/wrapping label) is verified against the set
of static `<label for="X">` values collected from the same template.
Inputs without a matching label are flagged.

Implementation:
- Single visitor pass collects `for` values into a Set
- Id-only controls are deferred to Program:exit so forward-declared
  labels are captured (label after input)
- Dynamic `id` / `for` (mustache paths, helper invocations,
  `(unique-id)` bindings) fall back to the existing skip behaviour —
  we deliberately don't resolve bindings symbolically
- Set lookup keeps cross-reference O(n + m)

Default off because Ember apps frequently split label/input across
component templates (design system wrappers); enabling without that
caveat would false-positive on those patterns. Documented in the rule
docs.

Author: johanrd

docs/rules/template-require-input-label.md

@@ -115,6 +115,7 @@ This rule **allows** the following:
 - boolean - `true` to enable / `false` to disable
 - object -- An object with the following keys:
   - `labelTags` -- An array of component names for that may be used as label replacements (in addition to the HTML `label` tag)
+  - `checkLabelFor` -- Boolean (default `false`). When `true`, an input with only an `id` attribute (no `aria-label`/`aria-labelledby`/wrapping `<label>`) is verified by looking for a sibling `<label for="X">` with a matching value in the same template. Inputs with no matching label are flagged. Both `id` and `for` must be static strings to be cross-referenced; dynamic values (e.g. `id={{this.fieldId}}` or the common `(unique-id)` helper pattern) fall back to the default skip behaviour. **This option may produce false positives** in apps where labels and form controls live in separate component templates — leave it disabled in that case.
 
 ## References
 

lib/rules/template-require-input-label.js

@@ -2,6 +2,23 @@ function hasAttr(node, name) {
   return node.attributes?.some((a) => a.name === name);
 }
 
+function getStaticAttrStr(node, name) {
+  const attr = node.attributes?.find((a) => a.name === name);
+  if (!attr || !attr.value) {
+    return null;
+  }
+  if (attr.value.type === 'GlimmerTextNode') {
+    return attr.value.chars.trim();
+  }
+  if (
+    attr.value.type === 'GlimmerMustacheStatement' &&
+    attr.value.path?.type === 'GlimmerStringLiteral'
+  ) {
+    return attr.value.path.value.trim();
+  }
+  return null; // dynamic — can't determine statically
+}
+
 function isString(value) {
   return typeof value === 'string';
 }
@@ -20,16 +37,20 @@ function parseConfig(config) {
   }
 
   if (config === true || config === undefined) {
-    return { labelTags: ['label'] };
+    return { labelTags: ['label'], checkLabelFor: false };
   }
 
-  if (config && typeof config === 'object' && Array.isArray(config.labelTags)) {
+  if (config && typeof config === 'object') {
+    const labelTags = Array.isArray(config.labelTags)
+      ? ['label', ...config.labelTags.filter(allowedFormat)]
+      : ['label'];
     return {
-      labelTags: ['label', ...config.labelTags.filter(allowedFormat)],
+      labelTags,
+      checkLabelFor: config.checkLabelFor === true,
     };
   }
 
-  return { labelTags: ['label'] };
+  return { labelTags: ['label'], checkLabelFor: false };
 }
 
 function matchesLabelTag(tag, configuredTag) {
@@ -56,6 +77,9 @@ module.exports = {
               labelTags: {
                 type: 'array',
               },
+              checkLabelFor: {
+                type: 'boolean',
+              },
             },
             additionalProperties: false,
           },
@@ -88,6 +112,13 @@ module.exports = {
     // Only populated in GJS/GTS files via ImportDeclaration
     const importedFormComponents = new Map();
 
+    // checkLabelFor: collect static <label for="X"> values into a Set and
+    // defer id-only controls until Program:exit so forward-declared labels
+    // are captured too. Single visitor pass + O(1) Set lookup keeps the
+    // cross-reference O(n + m) total (n = label nodes, m = id-only controls).
+    const labelForValues = new Set();
+    const pendingIdNodes = []; // { node } — reported if no matching for= found
+
     function hasValidLabelParent() {
       for (let i = elementStack.length - 1; i >= 0; i--) {
         const entry = elementStack[i];
@@ -127,6 +158,14 @@ module.exports = {
       GlimmerElementNode(node) {
         elementStack.push({ tag: node.tag, node });
 
+        // Collect <label for="X"> values for the checkLabelFor option.
+        if (config.checkLabelFor && node.tag === 'label') {
+          const forValue = getStaticAttrStr(node, 'for');
+          if (forValue) {
+            labelForValues.add(forValue);
+          }
+        }
+
         const tag = node.tag;
         // Is this tag one we should check?
         // - Native <input>/<textarea>/<select> always.
@@ -173,11 +212,18 @@ module.exports = {
           return;
         }
 
-        // id alone is treated as a potential <label for> reference that static
-        // analysis cannot verify (see vuejs-accessibility form-control-has-label
-        // for the same rationale). Skip only when no other label is present to
-        // avoid a false positive when id is combined with aria-label/labelledby.
+        // id alone is treated as a potential <label for> reference. When
+        // checkLabelFor is off we can't verify it statically so we skip;
+        // when it's on we defer the check to Program:exit where we have
+        // the full set of <label for> values from the same template.
         if (labelCount === 0 && hasAttr(node, 'id')) {
+          if (config.checkLabelFor) {
+            const idValue = getStaticAttrStr(node, 'id');
+            if (idValue) {
+              pendingIdNodes.push({ node, id: idValue });
+            }
+            // Dynamic id — can't match statically, fall back to skip.
+          }
           return;
         }
 
@@ -230,6 +276,17 @@ module.exports = {
           messageId: 'requireLabel',
         });
       },
+
+      'Program:exit'() {
+        if (!config.checkLabelFor) {
+          return;
+        }
+        for (const { node, id } of pendingIdNodes) {
+          if (!labelForValues.has(id)) {
+            context.report({ node, messageId: 'requireLabel' });
+          }
+        }
+      },
     };
   },
 };

tests/lib/rules/template-require-input-label.js

@@ -67,6 +67,45 @@ ruleTester.run('template-require-input-label', rule, {
       code: '<template><input /></template>',
       options: [false],
     },
+    // checkLabelFor: label before input
+    {
+      code: '<template><label for="email">Email</label><input id="email" /></template>',
+      options: [{ checkLabelFor: true }],
+    },
+    // checkLabelFor: label after input (forward reference resolved at Program:exit)
+    {
+      code: '<template><input id="email" /><label for="email">Email</label></template>',
+      options: [{ checkLabelFor: true }],
+    },
+    // checkLabelFor: input also has aria-label — not id-only, so not checked
+    {
+      code: '<template><input id="email" aria-label="Email" /></template>',
+      options: [{ checkLabelFor: true }],
+    },
+    // checkLabelFor: dynamic id — can't match statically, falls back to skip
+    {
+      code: '<template><input id={{this.fieldId}} /></template>',
+      options: [{ checkLabelFor: true }],
+    },
+    // checkLabelFor: the common Ember `(unique-id)` pattern uses dynamic
+    // bindings on both sides — both for= and id= are dynamic, so neither is
+    // collected, and the input falls back to the skip-if-id-present branch.
+    // We deliberately don't resolve the {{#let}} binding symbolically.
+    {
+      code: '<template>{{#let (unique-id) as |myId|}}<label for={{myId}}>Name</label><input id={{myId}} />{{/let}}</template>',
+      options: [{ checkLabelFor: true }],
+    },
+    // checkLabelFor: combined with labelTags — a CustomLabel wrapper still
+    // satisfies the label requirement (same as without checkLabelFor).
+    {
+      code: '<template><CustomLabel><input id="email" /></CustomLabel></template>',
+      options: [{ labelTags: ['CustomLabel'], checkLabelFor: true }],
+    },
+    // checkLabelFor: mustache string-literal for= collected correctly
+    {
+      code: '<template><label for={{"email"}}>Email</label><input id="email" /></template>',
+      options: [{ checkLabelFor: true }],
+    },
   ],
   invalid: [
     {
@@ -149,6 +188,27 @@ ruleTester.run('template-require-input-label', rule, {
       output: null,
       errors: [{ message: NO_LABEL }],
     },
+    // checkLabelFor: id with no matching <label for> in the same template
+    {
+      code: '<template><input id="email" /></template>',
+      output: null,
+      options: [{ checkLabelFor: true }],
+      errors: [{ message: NO_LABEL }],
+    },
+    // checkLabelFor: id with a mismatched for= (typo)
+    {
+      code: '<template><label for="emal">Email</label><input id="email" /></template>',
+      output: null,
+      options: [{ checkLabelFor: true }],
+      errors: [{ message: NO_LABEL }],
+    },
+    // checkLabelFor: two inputs, only one has a matching label
+    {
+      code: '<template><label for="name">Name</label><input id="name" /><input id="email" /></template>',
+      output: null,
+      options: [{ checkLabelFor: true }],
+      errors: [{ message: NO_LABEL }],
+    },
   ],
 });
 
@@ -216,6 +276,25 @@ hbsRuleTester.run('template-require-input-label', rule, {
       code: '<input />',
       options: [false],
     },
+    // checkLabelFor: label before/after input within the same .hbs file
+    {
+      code: '<label for="email">Email</label><input id="email" />',
+      options: [{ checkLabelFor: true }],
+    },
+    {
+      code: '<input id="email" /><label for="email">Email</label>',
+      options: [{ checkLabelFor: true }],
+    },
+    // checkLabelFor: id with aria-label is not deferred
+    {
+      code: '<input id="email" aria-label="Email" />',
+      options: [{ checkLabelFor: true }],
+    },
+    // checkLabelFor: dynamic id falls back to skip
+    {
+      code: '<input id={{this.fieldId}} />',
+      options: [{ checkLabelFor: true }],
+    },
   ],
   invalid: [
     {
@@ -309,5 +388,19 @@ hbsRuleTester.run('template-require-input-label', rule, {
       output: null,
       errors: [{ message: MULTIPLE_LABELS }],
     },
+    // checkLabelFor: id with no matching <label for> in the same .hbs file
+    {
+      code: '<input id="email" />',
+      output: null,
+      options: [{ checkLabelFor: true }],
+      errors: [{ message: NO_LABEL }],
+    },
+    // checkLabelFor: typo in for= attribute
+    {
+      code: '<label for="emal">Email</label><input id="email" />',
+      output: null,
+      options: [{ checkLabelFor: true }],
+      errors: [{ message: NO_LABEL }],
+    },
   ],
 });