Merge pull request #2700 from johanrd/day_fix/template-require-media-caption

Post-merge-review: Fix template-require-media-caption: skip caption check when muted is dynamic

Author: NullVoxPopuli

lib/rules/template-require-media-caption.js

@@ -53,6 +53,13 @@ module.exports = {
               return;
             }
           }
+
+          // Any other dynamic value (e.g. muted="{{isMuted}}" → ConcatStatement,
+          // or muted={{#if ...}}...{{/if}} → BlockStatement) → treat as exempt.
+          // These cannot be statically evaluated, so assume the element may be muted.
+          if (value.type !== 'GlimmerTextNode' && value.type !== 'GlimmerMustacheStatement') {
+            return;
+          }
         }
 
         // Check if there's a track element with kind="captions" as a child

tests/lib/rules/template-require-media-caption.js

@@ -34,6 +34,8 @@ ruleTester.run('template-require-media-caption', rule, {
     '<template><audio muted="true"></audio></template>',
     '<template><video muted></video></template>',
     '<template><audio muted={{this.muted}}></audio></template>',
+    '<template><video muted="{{isMuted}}"><source src="movie.mp4" /></video></template>',
+    '<template><audio muted="{{this.isMuted}}"></audio></template>',
     '<template><video><track kind="captions" /><track kind="descriptions" /></video></template>',
   ],
 
@@ -148,6 +150,8 @@ hbsRuleTester.run('template-require-media-caption', rule, {
     '<audio muted="true"></audio>',
     '<video muted></video>',
     '<audio muted={{this.muted}}></audio>',
+    '<video muted="{{isMuted}}"><source src="movie.mp4" /></video>',
+    '<audio muted="{{this.isMuted}}"></audio>',
     '<video><track kind="captions" /><track kind="descriptions" /></video>',
   ],
   invalid: [