Skip to content

Commit f68e6c3

Browse files
committed
breaking: enable template-no-let-reference as recommended
1 parent b1a7972 commit f68e6c3

4 files changed

Lines changed: 5 additions & 2 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ rules in templates can be disabled with eslint directives with mustache or html
241241
| [no-empty-glimmer-component-classes](docs/rules/no-empty-glimmer-component-classes.md) | disallow empty backing classes for Glimmer components || | |
242242
| [no-tracked-properties-from-args](docs/rules/no-tracked-properties-from-args.md) | disallow creating @tracked properties from this.args || | |
243243
| [template-indent](docs/rules/template-indent.md) | enforce consistent indentation for gts/gjs templates | | 🔧 | |
244-
| [template-no-let-reference](docs/rules/template-no-let-reference.md) | disallow referencing let variables in \<template\> | | | |
244+
| [template-no-let-reference](docs/rules/template-no-let-reference.md) | disallow referencing let variables in \<template\> | | | |
245245

246246
### jQuery
247247

docs/rules/template-no-let-reference.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# ember/template-no-let-reference
22

3+
💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/ember-cli/eslint-plugin-ember#-configurations).
4+
35
<!-- end auto-generated rule header -->
46

57
Disallows referencing let/var variables in templates.

lib/recommended-rules.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ module.exports = {
7373
"ember/require-tagless-components": "error",
7474
"ember/require-valid-css-selector-in-test-helpers": "error",
7575
"ember/routes-segments-snake-case": "error",
76+
"ember/template-no-let-reference": "error",
7677
"ember/use-brace-expansion": "error",
7778
"ember/use-ember-data-rfc-395-imports": "error"
7879
}

lib/rules/template-no-let-reference.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ module.exports = {
55
docs: {
66
description: 'disallow referencing let variables in \\<template\\>',
77
category: 'Ember Octane',
8-
recommended: false,
8+
recommended: true,
99
url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-let-reference.md',
1010
},
1111
fixable: null,

0 commit comments

Comments
 (0)