Merge pull request #2671 from johanrd/night_fix/template-no-outlet-outside-routes

Post-merge-review: Fix `template-no-outlet-outside-routes` false positive on imported `outlet`

Author: NullVoxPopuli

lib/rules/template-no-outlet-outside-routes.js

@@ -51,13 +51,33 @@ module.exports = {
   },
 
   create(context) {
+    const sourceCode = context.sourceCode;
     const filename = context.filename;
 
     const routeTemplate = isRouteTemplate(filename);
 
+    function isJsScopeVariable(node) {
+      if (!sourceCode || !node.path?.original) {
+        return false;
+      }
+      const name = node.path.original;
+      try {
+        let scope = sourceCode.getScope(node);
+        while (scope) {
+          if (scope.variables.some((v) => v.name === name)) {
+            return true;
+          }
+          scope = scope.upper;
+        }
+      } catch {
+        // sourceCode.getScope may not be available in .hbs-only mode; ignore.
+      }
+      return false;
+    }
+
     function checkForOutlet(node) {
       if (node.path.type === 'GlimmerPathExpression' && node.path.original === 'outlet') {
-        if (!routeTemplate) {
+        if (!routeTemplate && !isJsScopeVariable(node)) {
           context.report({
             node,
             messageId: 'noOutletOutsideRoutes',

tests/lib/rules/template-no-outlet-outside-routes.js

@@ -30,6 +30,17 @@ ruleTester.run('template-no-outlet-outside-routes', rule, {
       filename: 'app/routes/foo.gjs',
       code: '<template>{{#outlet}}content{{/outlet}}</template>',
     },
+    // GJS/GTS: imported JS bindings are not flagged
+    {
+      filename: 'app/components/my-component.gjs',
+      code: `import outlet from './my-outlet';
+export default <template>{{outlet}}</template>;`,
+    },
+    {
+      filename: 'app/components/my-component.gts',
+      code: `import outlet from '@company/ui';
+export default <template>{{outlet}}</template>;`,
+    },
   ],
   invalid: [
     // Co-located component (explicit filename)