Plan v12 Release

[bmish]

We are waiting until we have enough breaking changes before proceeding with this release.

If there isn't much urgency with any specific breaking changes, then we normally just wait until we can drop Node versions before a release. If there are changes that we need/want to get out sooner, we can consider an earlier release. Please comment if a major release would be helpful.

Planned changes:

• New recommended rules:
  • Add new recommended rules: no-at-ember-render-modifiers, no-deprecated-router-transition-methods, no-implicit-injections, no-runloop, no-tracked-properties-from-args, #1963
  • Add new recommended rule: template-no-let-reference #1977
• Change option defaults:
  • Change useAt option default to true at in no-get rule #1965
• Drop old Node versions
  • Drop support for Node 14, 16, 19 #1962
• ESLint v8
  • Drop support for ESLint 7 #1967
  • Set config ecmaVersion to 2022 #1978
• Update dependencies
  • Update almost all dependencies #1975
  • Update eslint-plugin-unicorn to v49 #1974
  • Update @typescript-eslint/ dependencies to v6 #1984
  • Update all dependencies #2042
• gjs/gts
  • Use custom parser for gts/gjs #1942
  • Add gts/gjs configs #1944
  • ...

Releases:

• https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v12.0.0-alpha.4
• https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v12.0.0-alpha.3
• https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v12.0.0-alpha.2
• https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v12.0.0-alpha.1
• https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v12.0.0-alpha.0
• For reference, the v11 release took place on 2022-07-20 (Plan v11 Release #1169).

[patricklx]

there is also

• Add new rule no-at-ember-render-modifiers #1902 <-- should that also be included as new recommended? @NullVoxPopuli ?
• Add new rule template-no-let-reference #1939
• Add new rule template-indent #1943
• Use custom parser for gts/gjs #1942
• Add gts/gjs configs #1944

[NullVoxPopuli]

Yup! Thank you!

[bmish]

@patricklx if #1939 should be enabled as a recommended rule, can you open a PR to do that? Any other changes to complete?

I'm thinking we should release an alpha version with all these changes so people can test them out, given the revert that happened in the last release.

CC: @NullVoxPopuli

[NullVoxPopuli]

i think it should!

[bmish]

@patricklx can you open PRs for:

1. Enable template-no-let-reference as recommended. UPDATE: I did it here: Add new recommended rule: template-no-let-reference #1977
2. Update all @typescript-eslint/ deps since this causes some test failures including some tests you added recently (make sure we are compatible with v5 and v6 of these deps) (I finished updating all other deps).

Then I think we're ready for an alpha release.

[patricklx]

@patricklx can you open PRs for:

1. Enable template-no-let-reference as recommended. UPDATE: I did it here: Add new recommended rule: template-no-let-reference #1977
2. Update all @typescript-eslint/ deps since this causes some test failures including some tests you added recently (make sure we are compatible with v5 and v6 of these deps) (I finished updating all other deps).

Then I think we're ready for an alpha release.

For the typescript dependencies I will look into it on Monday

[bmish]

Sounds good. Here is the first alpha version. Please help test it: https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v12.0.0-alpha.0

[bmish]

Second alpha version, please test: https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v12.0.0-alpha.1

[bmish]

@NullVoxPopuli @patricklx how close do you think we are to releasing v12.0.0? Are any more breaking changes still needed? Is gjs/gts fairly stable? It doesn't have to be perfect since bug fixes can continue after the release, but should be in good shape.