Lint Gjs/Gts warning only disappears after adding `ember-eslint-parser` as a dev dependency

[hashicc]

I've been trying to get rid of the warning:

[lint:js] To lint Gjs/Gts files please follow the setup guide at https://github.com/ember-cli/eslint-plugin-ember#gtsgjs
[lint:js] Note that this error can also happen if you have multiple versions of eslint-plugin-ember in your node_modules

I have this bit in my eslintrc overrides

    {
      files: ['**/*.gjs'],
      parser: 'ember-eslint-parser',
      plugins: ['ember'],
      extends: [
        'eslint:recommended',
        'plugin:ember/recommended',
        'plugin:ember/recommended-gjs',
      ],
    }

My first step was to make sure there weren't multiple copies of eslint-plugin-ember installed. I used pnpm why -r eslint-plugin-ember. There was only one installed, the monorepo workspaces all referenced the same eslint-plugin-ember. I double-checked this by checking node_modules/.pnpm/store.

I was starting to wonder if it was even being loaded at all. In my eslint config changing parser: 'ember-eslint-parser' to parser: 'ember-eslint-parser-asdf' caused an error, so it was at least looking for the package. The next step I did was go to the source of ember-eslint-parser in my node_modules and modify directly the gjs-gts-parser.jsfile:

  parseForESLint(code, options) {
    throw new Error("Error thrown from `parseForESLint`");
    patchTs();
    /* ... */
  }

Since this is the entry point for eslint to use for the parser I thought this would fail, but when I ran my pnpm lint I still received the "To lint Gjs/Gts files please follow the setup guide..." warning, and did not see the error being thrown.

After adding ember-eslint-parser with pnpm add --save-dev ember-eslint-parser and then re-running pnpm lint, I got:

0:0  error  Parsing error: Error thrown from `parseForESLint`

So the throw I hacked into the ember-eslint-parser source was finally showing up. I removed my modification, and re-ran pnpm lint and no warnings or errors related to "To lint Gjs/Gts files please follow the setup guide" show up, neither via pnpm lint or in vscode.

I know this isn't the correct setup since ember-eslint-parser is a dependency of eslint-plugin-ember but I don't know why else this worked. Any ideas what's wrong in my setup?

[NullVoxPopuli]

are you using eslint 8 or 9?

do you have a reproduction repo?

Thanks!!!

[hashicc]

Thanks for checking in!
I'm using eslint 8. Let me see if I can get a reproduction repo set up

[hashicc]

Here's an example reproduction with the issue commit-by-commit. The latest commit has ember-eslint-parser added as a dev dependency and there's no errors in my hello.gjs, and the previous commit without ember-eslint-parser as a dev dependency has the lint warning.

I'm not sure if a pnpm monorepo is necessary for reproduction but wanted to keep it similar to our setup where the issue does exist. The example pnpm monorepo reproduction only has one workspace/package so there isn't really opportunities for multiple dependency chains which is verified by pnpm why -r.

Let me know if there's anything else I can provide and thanks for any insights. We're really excited to give the .gjs components a go!

[patricklx]

@hashicc you repro is not accessible

[hashicc]

@patricklx my bad, fixed!

[kdagnan]

Also experiencing this issue. Adding ember-eslint-parser as a devDependency fixes it.

[hashicc]

The sample repo I have reproduces the issue but I'm not sure which specific variable(s) are causing the issue.

@kdagnan thanks for confirming you're also seeing this. Can you provide some context on your setup, are you using:

1. pnpm
2. workspaces (monorepo)
3. eslint 8 or 9

Thanks!

[kdagnan]

I am using:

• pnpm 10.13
• node 18.19
• pnpm workspaces
• eslint 8.57
• eslint-plugin-ember 12.5