Post-merge-review: Fix template-no-chained-this autofix: also update the closing tag#2656
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Apr 13, 2026
Conversation
…g elements The GlimmerElementNode fixer only replaced the opening tag name but not the closing tag, causing a parse error in autofix output for elements like <this.this.Component>content</this.this.Component>. Now both tags are fixed correctly.
NullVoxPopuli
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken on
masterFor
GlimmerElementNodeautofix, master replaces only the opening tag name. For non-self-closing elements this produces invalid HTML:Fix
When
!node.selfClosing, return a secondreplaceTextRangefor the closing tag name. Upstream gets this for free because it mutatesnode.tagdirectly andember-template-recastserializes both tags from the single property (no-chained-this.jsL28). The port's ESLint fixer operates on text ranges, so both tags need explicit handling.Test plan
<this.this.Foo>text</this.this.Foo>) fails on master with a parse error in the autofix outputCo-written by Claude.