Post-merge-review: Fix template-no-empty-headings: recognize <this.X>, <@x>, <ns.X> as accessible content#2663
Open
johanrd wants to merge 1 commit intoember-cli:masterfrom
Open
Conversation
…ldren GTS component invocations can appear as <this.Foo>, <@foo>, or <ns.Foo> in addition to PascalCase. The rule's isComponent() check was too narrow, so children of headings using these forms were not recognized as content and the heading was falsely flagged as empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken on
masterisComponentonly considers PascalCase tags orFoo::Barnested-component syntax. It misses three valid GTS component invocation forms per the template tag format guide:<this.Heading>(class-scoped component reference)<@heading>(argument-passed component)<ns.Heading>(dot-path re-export)When one of these appears as the only child of a heading, the rule walks the child list, fails to identify it as a component, and reports the heading as empty.
Fix
Extend
isComponentwith three additional conditions:tag.startsWith('this.'),tag.startsWith('@'),tag.includes('.'). All three are component forms that cannot be HTML elements in any mode (HTML doesn't allowthis./@/.in tag names).Test plan
<h1><this.Heading />,<h2><@heading />,<h3><ns.Heading />) all fail on masterCo-written by Claude.