Post-merge-review: Fix template-deprecated-render-helper false positive in GJS/GTS#2665
Open
johanrd wants to merge 1 commit intoember-cli:masterfrom
Open
Post-merge-review: Fix template-deprecated-render-helper false positive in GJS/GTS#2665johanrd wants to merge 1 commit intoember-cli:masterfrom
template-deprecated-render-helper false positive in GJS/GTS#2665johanrd wants to merge 1 commit intoember-cli:masterfrom
Conversation
The {{render}} helper is classic-Ember-only; in GJS/GTS files, `render`
is a legitimate JS binding (e.g. from @ember/test-helpers) and must not
be flagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken on
masterThe rule flags
{{render ...}}as the classic Ember resolver-resolved helper. In GJS/GTS,renderis commonly imported from@ember/test-helpersor@testing-library/ember— unrelated to the classic{{render}}helper.templateMode: 'loose'metadata is not runtime-enforced.Fix
Gate to
.hbsfiles only. The classic helper cannot be reached in strict mode.Test plan
27/27 tests pass. 2 new GJS/GTS valid tests fail on master.
Co-written by Claude.