Post-merge-review: Fix template-deprecated-inline-view-helper false positive in GJS/GTS#2666
Open
johanrd wants to merge 1 commit intoember-cli:masterfrom
Open
Conversation
The {{view}} and view.* patterns are classic Ember only; in GJS/GTS
files, `view` may be a legitimate imported JS binding or local variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken on
masterFlags
{{view ...}}andview.*paths. Block-param shadowing is tracked but JS imports/consts are not, so in GJS/GTS a legitimateimport view from '…'would be flagged.Fix
Gate to
.hbsonly. The classicviewhelper/namespace only exists in HBS.Test plan
53/53 tests pass. 2 new GJS valid tests fail on master.
Co-written by Claude.