Post-merge-review: Fix template-no-class-bindings false positive in GJS/GTS#2667
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Apr 13, 2026
Merged
Conversation
classBinding/classNameBindings are classic Ember mixin properties; in GJS/GTS files a component may legitimately accept @classBinding as an argument with any meaning.
NullVoxPopuli
approved these changes
Apr 13, 2026
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken on
masterFlags
classBinding/classNameBindingsattributes as classic-Ember mixin patterns. In GJS/GTS a user-authored component could legitimately accept these as argument names with any meaning.Fix
Gate to
.hbsonly.Test plan
19/19 tests pass. 2 new GJS valid tests fail on master.
Co-written by Claude.