Post-merge-review: Fix template-no-outlet-outside-routes false positive on imported outlet#2671
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Apr 13, 2026
Conversation
|
|
||
| const routeTemplate = isRouteTemplate(filename); | ||
|
|
||
| function isJsScopeVariable(node) { |
Contributor
There was a problem hiding this comment.
this could probably be a shared utility as well, but I feel like there would be a better way to do this -- it's a lot of code and iirc there was a nicer API on the scope to get your answer here
NullVoxPopuli
approved these changes
Apr 13, 2026
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken on
masterFlags
{{outlet}}in non-route templates. Doesn't check whetheroutletresolves to a JS binding — in GJS/GTS a user couldimport outlet from '…'and use it in any component.Fix
Add JS scope check alongside the existing route-template filename check.
Test plan
25/25 tests pass. 2 new GJS valid tests with imported
outletfail on master.Co-written by Claude.