Post-merge-review: Fix template-require-has-block-helper: skip JS scope bindings#2673
Open
johanrd wants to merge 1 commit intoember-cli:masterfrom
Open
Post-merge-review: Fix template-require-has-block-helper: skip JS scope bindings#2673johanrd wants to merge 1 commit intoember-cli:masterfrom
template-require-has-block-helper: skip JS scope bindings#2673johanrd wants to merge 1 commit intoember-cli:masterfrom
Conversation
The rule rewrites hasBlock/hasBlockParams to has-block/has-block-params (Glimmer keywords). In GJS/GTS, a user could legitimately import or declare their own hasBlock binding, and the rule would incorrectly rewrite their reference to the built-in keyword, changing semantics. Add a JS scope check (walking scope.variables up the chain) and skip the report when the identifier resolves to a user binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken on
masterFlags
hasBlock/hasBlockParamsand rewrites them tohas-block/has-block-params(Glimmer keywords). In GJS/GTS, a user could import their ownhasBlock— and the autofix would silently replace their reference with the built-in keyword, changing semantics.Fix
Add JS scope check. Skip the report when the identifier resolves to a user binding.
Test plan
64/64 tests pass. 2 new GJS valid tests fail on master.
Co-written by Claude.