Post-merge-review: Fix template-no-whitespace-for-layout false positive on attribute values#2681
Merged
NullVoxPopuli merged 3 commits intoember-cli:masterfrom Apr 15, 2026
Conversation
The rule's GlimmerTextNode visitor fired on attribute value text nodes (e.g. `<div class="foo bar">`), reporting layout-whitespace violations for consecutive spaces inside class lists and other attribute values. Upstream ember-template-lint only visits body text, since its HBS parser exposes attribute values differently. Skip GlimmerTextNodes whose parent is a GlimmerAttrNode.
johanrd
force-pushed
the
false_positive/template-no-whitespace-for-layout
branch
from
9018b60 to
92b6d17
Compare
Replace the Tailwind-specific valid case with a style attribute example where consecutive spaces are more clearly intentional. Add a comment referencing ember-template-lint#2899 to explain why attr values must not be flagged.
NullVoxPopuli
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule's GlimmerTextNode visitor fired on attribute value text nodes (e.g.
<div class="foo bar">), reporting layout-whitespace violations for consecutive spaces inside class lists and other attribute values.Upstream ember-template-lint only visits body text, since its HBS parser exposes attribute values differently. Skip GlimmerTextNodes whose parent is a GlimmerAttrNode.