Fix template-no-attrs-in-components: align detection with upstream#2688
Open
johanrd wants to merge 3 commits intoember-cli:masterfrom
Open
Fix template-no-attrs-in-components: align detection with upstream#2688johanrd wants to merge 3 commits intoember-cli:masterfrom
johanrd wants to merge 3 commits intoember-cli:masterfrom
Conversation
The port flagged this.attrs.* (which is not a real Ember API) and ran on all templates. Upstream gates on file path (templates/components/, components/*/template, ui/components/, -components/) and flags bare attrs.* — the pre-Octane args-leakage pattern. Restore upstream's behavior.
johanrd
force-pushed
the
day_fix/template-no-attrs-in-components
branch
from
1577807 to
11afc7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attrs.*(notthis.attrs.*which is a non-existent API)templateMode: 'loose'andoriginallyFrommetadataTest plan
{{attrs.foo}}in component template path → flagged{{this.attrs.foo}}→ never flagged (not a real Ember API){{attrs.foo}}in non-component template path → not flagged