Fix template-no-block-params-for-html-elements: align HTML-element detection#2689
Open
johanrd wants to merge 1 commit intoember-cli:masterfrom
Open
Conversation
…tection with upstream Replace static htmlTags package check with inverse-of-component-detection (reject tags with : / . / uppercase / @ / -). Custom elements like <my-element as |x|> are no longer false-flagged.
johanrd
force-pushed
the
day_fix/template-no-block-params-for-html-elements
branch
from
a6eaaf3 to
f6dcffa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
html-tagspackage check with inverse-of-isAngleBracketComponentlogic (mirrors upstream)<my-element as |x|>) no longer false-positively flaggedWhy not just extend
html-tags?HTML is an open namespace — the browser parses any unknown lowercase tag as an
HTMLUnknownElement(still HTML, still doesn't accept block params). The old allowlist-based check missed this class of false negative:<foo as |x|>{{x}}</foo>wasn't flagged becausefooisn't inhtml-tags, but it should be. Extending the list (SVG, MathML, obsolete, etc.) only moves the gap — you'd end up enumerating "any lowercase identifier." Flipping the question to "is this not a component invocation?" is bounded (uppercase /./@/-/:) and matches upstream's long-standing approach.Test plan