Post-merge-review: Fix template-no-mut-helper: templateMode 'both' and unwrap setterAlternative#2692
Merged
NullVoxPopuli merged 3 commits intoember-cli:masterfrom Apr 14, 2026
Conversation
…rnative
mut is a strict-mode ambient keyword (STRICT_MODE_KEYWORDS), so the rule
must run in .gjs/.gts too — not just .hbs. Also: stop double-wrapping
setterAlternative — the user's expression should be wrapped in {{...}}
exactly once in the suggested replacement.
johanrd
force-pushed
the
day_fix/template-no-mut-helper
branch
from
376d5ca to
e4ab056
Compare
johanrd
changed the title
NullVoxPopuli
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
templateModefrom'loose'to'both'—mutis a strict-mode ambient keyword so the rule must run in.gjs/.gts{{...}}wrapping fromsetterAlternativeoption so the message shows exactly one level of bracesTest plan
<template>{{mut foo bar}}</template>→ flagged in GJS contextsetterAlternative: '{{(set this.foo)}}'→ message shows{{(set this.foo)}}not{{{{(set this.foo)}}}}