template-no-negated-comparison: document name-clash; drop non-standard 'ne'#2693
Open
johanrd wants to merge 1 commit intoember-cli:masterfrom
Open
template-no-negated-comparison: document name-clash; drop non-standard 'ne'#2693johanrd wants to merge 1 commit intoember-cli:masterfrom
johanrd wants to merge 1 commit intoember-cli:masterfrom
Conversation
… 'ne' This rule is NOT a port of upstream's no-negated-condition — they have opposite goals. Adds a note to the rule docs to prevent migration confusion. Also removes the 'ne' alias which is not a real Ember truth-helper (only 'not-eq' is standard).
johanrd
force-pushed
the
day_fix/template-no-negated-comparison
branch
from
42394fc to
ece4355
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no-negated-condition— they have opposite goalsnealias:neis not a real Ember/ember-truth-helpers helper (not-eqis standard)Test plan
{{#if (ne this.a this.b)}}→ valid (not flagged){{#if (not-eq this.a this.b)}}→ still flagged