Post-merge-review: Fix template-require-aria-activedescendant-tabindex: autofix for non-div tags#2697
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Apr 14, 2026
Conversation
…n for non-div tags Replaces hardcoded '<div'.length with computed offset based on the actual tag name. Previous code mis-positioned the tabindex insertion on <a>, <button>, and other non-3-char tags.
johanrd
force-pushed
the
day_fix/template-require-aria-activedescendant-tabindex
branch
from
29e6293 to
7165f51
Compare
johanrd
changed the title
NullVoxPopuli
approved these changes
Apr 14, 2026
johanrd
deleted the
day_fix/template-require-aria-activedescendant-tabindex
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'<div'.lengthwith computed1 + node.tag.lengthtabindexinsertion on<a>,<button>, and other non-3-char tagsTest plan
<a aria-activedescendant="x">autofixes to<a aria-activedescendant="x" tabindex="0"><button aria-activedescendant="x" tabindex="-1">autofixes totabindex="0"