Fix template-require-mandatory-role-attributes: read StringLiteral .value not .original#2699
Open
johanrd wants to merge 1 commit intoember-cli:masterfrom
Open
Conversation
…alue not .original
The mustache branch was dead code due to an incorrect accessor on
GlimmerStringLiteral (.original returns undefined). Required-ARIA-property
errors on curly invocations like {{foo role="slider"}} were silently
dropped. Switch to .value to match the AST and add invalid-case tests.
johanrd
force-pushed
the
day_fix/template-require-mandatory-role-attributes
branch
from
8e8bb69 to
48d1c7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GlimmerStringLiteral.originalreturnsundefined;.valueis the correct accessor{{foo role="slider"}}were silently dropped; now reported correctlyTest plan
{{foo role="slider"}}→ flagged (missingaria-valuenow){{foo role="checkbox"}}→ flagged (missingaria-checked)