Post-merge-review: Fix template-require-media-caption: skip caption check when muted is dynamic#2700
Merged
NullVoxPopuli merged 3 commits intoember-cli:masterfrom Apr 14, 2026
Conversation
…dynamic
Port had no GlimmerConcatStatement handling for the muted attribute,
so <video muted="{{isMuted}}"> false-positively required captions.
Treat ConcatStatement (and other non-text values) as muted/exempt
to match upstream.
johanrd
force-pushed
the
day_fix/template-require-media-caption
branch
from
d7d8f84 to
e3a8d8b
Compare
johanrd
changed the title
|
|
||
| // Any other dynamic value (e.g. muted="{{isMuted}}" → ConcatStatement, | ||
| // or muted={{#if ...}}...{{/if}} → BlockStatement) → treat as exempt. | ||
| // Matches upstream ember-template-lint behavior where MustacheStatement, |
Contributor
There was a problem hiding this comment.
can we stop adding comments about "matches upstram" this means nothing post PR merge 🙈
NullVoxPopuli
approved these changes
Apr 14, 2026
NullVoxPopuli
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
muted="{{isMuted}}"(ConcatStatement) was not handled → false positive requiring captionsTest plan
<video muted="{{isMuted}}">→ valid (no caption required)<audio muted="{{this.isMuted}}">→ valid<video muted={{false}}>→ still requires captions (explicit false)