Fix template-table-groups: align with upstream's table semantics#2701
Open
johanrd wants to merge 1 commit intoember-cli:masterfrom
Open
Fix template-table-groups: align with upstream's table semantics#2701johanrd wants to merge 1 commit intoember-cli:masterfrom
johanrd wants to merge 1 commit intoember-cli:masterfrom
Conversation
Match upstream's scope-union reduce for sibling control-flow branches (was producing false positives on legitimate table layouts). Remove the port-only empty-table synthetic check, which over-flagged <table></table> beyond upstream's scope.
johanrd
force-pushed
the
day_fix/template-table-groups
branch
from
d3f3889 to
92a5cf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reducenow merges all ancestor scopes when entering a control-flow branch (was copying only the current scope)<table></table>Test plan
<table></table>→ valid (matches upstream)<table>{{#if ...}}<tbody>...</tbody>{{/if}}</table>→ valid (no false positive)<table>text<thead>...</thead></table>→ still flagged (whitespace before group)