Post-merge-review: add missing tests from ember-template-lint test suite#2705
Open
johanrd wants to merge 5 commits intoember-cli:masterfrom
Open
Post-merge-review: add missing tests from ember-template-lint test suite#2705johanrd wants to merge 5 commits intoember-cli:masterfrom
johanrd wants to merge 5 commits intoember-cli:masterfrom
Conversation
…e.md - template-no-nested-interactive: add test for ignoreUsemapAttribute alias - template-no-curly-component-invocation: add test for requireDash:true behavior - coverage.md: document all 134 template rules with status
0227c9d to
8518b24
Compare
…-actions tests Move `output` before `options` in test cases to satisfy eslint-plugin/test-case-property-ordering.
…ototype-extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Systematic comparison of all 134 template rules against the ember-template-lint test suite. 15 rules had missing test coverage.
Tests added
template-no-nested-interactiveignoreUsemapAttributeoption aliastemplate-no-curly-component-invocationrequireDash: truewith single-word named-arg calltemplate-no-abstract-rolestemplate-no-obsolete-elementstemplate-self-closing-void-elementsrequireconfig option — all void elements, valid and invalid with fixer outputtemplate-no-invalid-interactiveadditionalInteractiveTagsandignoredTagsconfig optionstemplate-no-aria-hidden-bodyaria-hiddenattribute without valuetemplate-no-invalid-rolecatchNonexistentRolesconfig optiontemplate-require-strict-modetemplate-link-rel-noopenertarget="_self"valid case; full HBS tester sectiontemplate-no-element-event-actionsrequireActionHelperconfig option (true and false)template-no-array-prototype-extensionsgethelper; plain-text and string-attr false-positive checks;lastObjectin named hash argtemplate-no-duplicate-landmark-elementspopoverelement scoping in GJS testertemplate-no-accesskey-attributeaccesskeyattribute, dynamic mustache value, and concat string attributeImplementation gaps evaluated
Three behaviors in ember-template-lint were found to have no equivalent tests or implementation in this plugin. Each was investigated and a decision made:
template-no-forbidden-elementshead.hbs)ember-cli-headis a classic-Ember-only addon; not relevant to GJS/GTStemplate-no-implicit-thisallowarraytemplate-no-bare-stringsfalseconfig to disable the rule"off"in ESLint config instead;falseis not idiomatic in ESLintTest plan
npm test— all tests pass