remove: template-no-negated-comparison#2709
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Apr 15, 2026
Merged
Conversation
Contributor
|
conflicst! |
This rule has no upstream equivalent in ember-template-lint and its premise is debatable: `not-eq` is a first-class ember-truth-helpers helper, so flagging it as wrong is a style opinion rather than a correctness concern. Additionally, it conflicts conceptually with the newly-restored `template-no-negated-condition`, which autofixes `(not (eq ...))` to `not-eq` — the opposite direction. Opening for NullVoxPopuli to decide.
johanrd
force-pushed
the
remove/template-no-negated-comparison
branch
from
a1912f7 to
e555454
Compare
Contributor
Author
|
thanks, fixed |
NullVoxPopuli
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposes removing
template-no-negated-comparison.Reasons:
not-eqis a first-class, standard ember-truth-helpers helper; flagging its use is a style opinion, not a correctness concerntemplate-no-negated-condition(restore: template-no-negated-condition (accidentally deleted in 133a16fc) #2708): that rule'ssimplifyHelpersmode autofixes(not (eq ...))→not-eq, i.e. towards the pattern this rule flagsOpening for NullVoxPopuli to decide — if there's appetite for a rule here, a narrower version flagging only the non-standard
nealias might make more sense than one flaggingnot-eqitself.Related: closes #2693 if merged (that PR was documenting the same tension).