Merge pull request #954 from ember-fastboot/node-versions

drop support for node < 20

Author: mansona

.github/workflows/ci.yml

@@ -26,12 +26,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v3
-        with:
-          version: 7
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 22
           cache: pnpm
       - run: pnpm install --frozen-lockfile
       - run: pnpm lint
@@ -44,15 +42,13 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [16.x, 14.x]
+        node-version: [20.x, 22.x, 24.x]
         os: [ubuntu-latest, windows-latest]
 
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v3
-        with:
-          version: 7
+      - uses: pnpm/action-setup@v4
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4
         with:
@@ -74,15 +70,13 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [16.x, 14.x]
+        node-version: [20.x, 22.x, 24.x]
         os: [ubuntu-latest, windows-latest]
 
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v3
-        with:
-          version: 7
+      - uses: pnpm/action-setup@v4
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4
         with:
@@ -101,14 +95,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [16.x, 14.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v3
-        with:
-          version: 7
+      - uses: pnpm/action-setup@v4
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4
         with:
@@ -144,12 +136,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v3
-        with:
-          version: 7
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 14
+          node-version: 22
           cache: pnpm
       - run: pnpm install --frozen-lockfile
       - name: test
@@ -163,12 +153,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v3
-        with:
-          version: 7
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 22
           cache: pnpm
       - run: pnpm install --frozen-lockfile
       - id: set-matrix
@@ -187,12 +175,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v3
-        with:
-          version: 7
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 22
           cache: pnpm
       - run: pnpm install --frozen-lockfile
       - name: test

package.json

@@ -23,5 +23,14 @@
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org"
-  }
+  },
+  "pnpm": {
+    "overrides": {
+      "clean-css@3": "^4.0.0"
+    },
+    "patchedDependencies": {
+      "ember-source@3.19.0": "patches/ember-source@3.19.0.patch"
+    }
+  },
+  "packageManager": "pnpm@10.17.0+sha512.fce8a3dd29a4ed2ec566fb53efbb04d8c44a0f05bc6f24a73046910fb9c3ce7afa35a0980500668fa3573345bd644644fa98338fa168235c80f4aa17aa17fbef"
 }

packages/ember-cli-fastboot/package.json

@@ -99,7 +99,7 @@
     "ember-source": ">=3.16"
   },
   "engines": {
-    "node": "14.* || 16.* || >= 18"
+    "node": "20.* || 22.* || >= 24"
   },
   "ember": {
     "edition": "octane"

packages/fastboot-app-server/package.json

@@ -45,7 +45,7 @@
     "request-promise": "^4.2.1"
   },
   "engines": {
-    "node": "12.* || 14.* || >=16"
+    "node": "20.* || 22.* || >= 24"
   },
   "volta": {
     "extends": "../../package.json"

packages/fastboot-express-middleware/package.json

@@ -45,7 +45,7 @@
     "request-promise": "^4.2.1"
   },
   "engines": {
-    "node": "12.* || 14.* || >=16"
+    "node": "20.* || 22.* || >= 24"
   },
   "volta": {
     "extends": "../../package.json"

packages/fastboot/package.json

@@ -56,7 +56,7 @@
     "tmp": "^0.2.1"
   },
   "engines": {
-    "node": "12.* || 14.* || >=16"
+    "node": "20.* || 22.* || >= 24"
   },
   "volta": {
     "extends": "../../package.json"

patches/ember-source@3.19.0.patch

@@ -0,0 +1,19 @@
+diff --git a/CHANGELOG.md b/CHANGELOG.md
+deleted file mode 100644
+index 1b2b830f141254893e8a23812dbb594bc8abe118..0000000000000000000000000000000000000000
+diff --git a/dist/packages/@ember/-internals/runtime/.gitignore b/dist/packages/@ember/-internals/runtime/.gitignore
+deleted file mode 100644
+index a1136368651e6eb6d0d93a09c478f4978f4196fa..0000000000000000000000000000000000000000
+diff --git a/dist/packages/ember-babel.js b/dist/packages/ember-babel.js
+index 167f6a7b9f30fe3446d839c486d1e5be7ee3909b..55859f2d082a9182b0edcd4784d87bd839fe9750 100644
+--- a/dist/packages/ember-babel.js
++++ b/dist/packages/ember-babel.js
+@@ -150,7 +150,7 @@ export function createSuper(Derived) {
+ /*
+   Does not differ from default implementation.
+ */
+-function arrayLikeToArray(arr, len) {
++export function arrayLikeToArray(arr, len) {
+   if (len == null || len > arr.length) len = arr.length;
+ 
+   let arr2 = new Array(len);