Merge pull request #960 from ember-fastboot/update

update ember-cli-fastboot to v5.12.0 with ember-cli-update

Author: mansona

.github/workflows/ci.yml

@@ -126,6 +126,7 @@ jobs:
           - ember-lts-4.8
           - ember-lts-4.12
           - ember-lts-5.4
+          - ember-lts-5.8
           - ember-release
           - ember-beta
           - ember-canary

CONTRIBUTING.md

@@ -19,15 +19,17 @@ The `test-packages` folder contains sample apps and integration test suite used
 
 * `git clone https://github.com/ember-fastboot/ember-cli-fastboot/`
 * `cd ember-cli-fastboot`
-* `yarn install`
+* `pnpm install`
 
 ## Running tests
 
-* `yarn workspace integration-tests test` - Run integration test suite
-* `yarn workspace basic-app test:mocha` - Run sample app's test suite
-* `yarn workspace ember-cli-fastboot test:ember` – Runs the `ember-cli-fastboot` test suite
+If you want to **all** the tests you can run 
 
-You can run each package's own test suite specified in its `package.json` via [`yarn workspace`](https://classic.yarnpkg.com/en/docs/cli/workspace#yarn-workspace-workspace_name-command-)
+```
+pnpm test
+```
+
+in the root of the monorepo. You will see that it is calling `npm-run-all` on other scripts listed in `package.json` with the prefix `test:` so if you want to run any specific test again you can just use that package.json sript
 
 ## Where to write test
 

packages/ember-cli-fastboot/package.json

@@ -14,16 +14,16 @@
   },
   "scripts": {
     "build": "ember build --environment=production",
-    "lint": "concurrently \"npm:lint:*(!fix)\" --names \"lint:\"",
+    "lint": "concurrently \"pnpm:lint:*(!fix)\" --names \"lint:\"",
     "lint:css": "stylelint \"**/*.css\"",
-    "lint:css:fix": "concurrently \"npm:lint:css -- --fix\"",
-    "lint:fix": "concurrently \"npm:lint:*:fix\" --names \"fix:\"",
+    "lint:css:fix": "concurrently \"pnpm:lint:css -- --fix\"",
+    "lint:fix": "concurrently \"pnpm:lint:*:fix\" --names \"fix:\"",
     "lint:hbs": "ember-template-lint .",
     "lint:hbs:fix": "ember-template-lint . --fix",
     "lint:js": "eslint . --cache",
     "lint:js:fix": "eslint . --fix",
     "start": "ember serve",
-    "test": "concurrently \"npm:lint\" \"npm:test:*\" --names \"lint,test:\"",
+    "test": "concurrently \"pnpm:lint\" \"pnpm:test:*\" --names \"lint,test:\"",
     "test:mocha": "mocha",
     "test:ember": "ember test",
     "test:ember-compatibility": "ember try:each"
@@ -49,18 +49,18 @@
     "silent-error": "^1.1.1"
   },
   "devDependencies": {
-    "@babel/eslint-parser": "^7.24.1",
-    "@babel/plugin-proposal-decorators": "^7.24.1",
+    "@babel/eslint-parser": "^7.25.1",
+    "@babel/plugin-proposal-decorators": "^7.24.7",
     "@ember/optional-features": "^2.1.0",
-    "@ember/test-helpers": "^3.3.0",
-    "@embroider/test-setup": "^3.0.3",
+    "@ember/test-helpers": "^3.3.1",
+    "@embroider/test-setup": "^4.0.0",
     "@glimmer/component": "^1.1.2",
     "@glimmer/tracking": "^1.1.2",
     "broccoli-asset-rev": "^3.0.0",
     "broccoli-test-helper": "^1.5.0",
     "concurrently": "^8.2.2",
-    "ember-auto-import": "^2.7.2",
-    "ember-cli": "~5.8.1",
+    "ember-auto-import": "^2.8.1",
+    "ember-cli": "~5.12.0",
     "ember-cli-clean-css": "^3.0.0",
     "ember-cli-dependency-checker": "^3.3.2",
     "ember-cli-htmlbars": "^6.3.0",
@@ -69,31 +69,31 @@
     "ember-cli-terser": "^4.0.2",
     "ember-load-initializers": "^2.1.2",
     "ember-page-title": "^8.2.3",
-    "ember-qunit": "^8.0.2",
-    "ember-resolver": "^11.0.1",
-    "ember-source": "~5.8.0",
+    "ember-qunit": "^8.1.0",
+    "ember-resolver": "^12.0.1",
+    "ember-source": "~5.12.0",
     "ember-source-channel-url": "^3.0.0",
-    "ember-template-lint": "^5.13.0",
+    "ember-template-lint": "^6.0.0",
     "ember-try": "^3.0.0",
-    "eslint": "^8.57.0",
+    "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-ember": "^11.12.0",
+    "eslint-plugin-ember": "^12.2.1",
     "eslint-plugin-n": "^16.6.2",
-    "eslint-plugin-prettier": "^5.1.3",
-    "eslint-plugin-qunit": "^8.1.1",
+    "eslint-plugin-prettier": "^5.2.1",
+    "eslint-plugin-qunit": "^8.1.2",
     "glob": "^7.1.3",
     "lint-to-the-future": "^2.0.0",
     "lint-to-the-future-eslint": "^2.0.1",
     "loader.js": "^4.7.0",
     "mocha": "^9.1.2",
-    "prettier": "^3.2.5",
-    "qunit": "^2.20.1",
-    "qunit-dom": "^2.0.0",
+    "prettier": "^3.3.3",
+    "qunit": "^2.22.0",
+    "qunit-dom": "^3.2.1",
     "sinon": "^17.0.1",
     "stylelint": "^15.11.0",
     "stylelint-config-standard": "^34.0.0",
     "stylelint-prettier": "^4.1.0",
-    "webpack": "^5.91.0"
+    "webpack": "^5.95.0"
   },
   "peerDependencies": {
     "ember-source": ">=3.16"

packages/ember-cli-fastboot/tests/dummy/config/ember-cli-update.json

@@ -3,15 +3,16 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "5.8.1",
+      "version": "5.12.0",
       "blueprints": [
         {
           "name": "addon",
           "outputRepo": "https://github.com/ember-cli/ember-addon-output",
           "codemodsSource": "ember-addon-codemods-manifest@1",
           "isBaseBlueprint": true,
           "options": [
-            "--no-welcome"
+            "--no-welcome",
+            "--pnpm"
           ]
         }
       ]

packages/ember-cli-fastboot/tests/dummy/config/ember-try.js

@@ -15,6 +15,7 @@ module.exports = async function () {
             'ember-qunit': '^5.0.0',
             'ember-cli': '^4.12.0',
             '@ember/test-helpers': '^2.4.0',
+            'ember-resolver': '^11.0.0',
           },
         },
       },
@@ -26,6 +27,7 @@ module.exports = async function () {
             'ember-qunit': '^5.0.0',
             'ember-cli': '^4.12.0',
             '@ember/test-helpers': '^2.4.0',
+            'ember-resolver': '^11.0.0',
           },
         },
       },
@@ -37,6 +39,7 @@ module.exports = async function () {
             'ember-qunit': '^5.0.0',
             'ember-cli': '^4.12.0',
             '@ember/test-helpers': '^2.4.0',
+            'ember-resolver': '^11.0.0',
           },
         },
       },
@@ -46,6 +49,7 @@ module.exports = async function () {
           devDependencies: {
             'ember-source': '~3.28.0',
             'ember-cli': '^4.12.0',
+            'ember-resolver': '^11.0.0',
           },
         },
       },
@@ -54,6 +58,7 @@ module.exports = async function () {
         npm: {
           devDependencies: {
             'ember-source': '~4.4.0',
+            'ember-resolver': '^11.0.0',
           },
         },
       },
@@ -62,6 +67,7 @@ module.exports = async function () {
         npm: {
           devDependencies: {
             'ember-source': '~4.8.0',
+            'ember-resolver': '^11.0.0',
           },
         },
       },
@@ -81,6 +87,14 @@ module.exports = async function () {
           },
         },
       },
+      {
+        name: 'ember-lts-5.8',
+        npm: {
+          devDependencies: {
+            'ember-source': '~5.8.0',
+          },
+        },
+      },
       {
         name: 'ember-release',
         npm: {

packages/ember-cli-fastboot/tests/helpers/index.js

@@ -23,7 +23,7 @@ function setupApplicationTest(hooks, options) {
   // This is also a good place to call test setup functions coming
   // from other addons:
   //
-  // setupIntl(hooks); // ember-intl
+  // setupIntl(hooks, 'en-us'); // ember-intl
   // setupMirage(hooks); // ember-cli-mirage
 }