Skip to content

Fix ember v6 deprecate-import-view-utils-from-ember deprecation #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mansona wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ember v6 deprecate-import-view-utils-from-ember deprecation #966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c6f853
Fix ember v6 deprecate-import-view-utils-from-ember deprecation
felixbuenemann Nov 10, 2025
0b35968
Use backwards compatible requires for experimental-render-mode-rehydrate
felixbuenemann Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions packages/ember-cli-fastboot/vendor/experimental-render-mode-rehydrate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,37 @@
if (typeof FastBoot === 'undefined') {
var current = document.getElementById('fastboot-body-start');

var _Ember = require.has('ember') ? require('ember').default : window.Ember;
if (!current) {
return;
}

var isSerializationFirstNode;
var ApplicationInstance;

if (require.has('@ember/-internals/glimmer') && require.has('@ember/application/instance')) {
isSerializationFirstNode = require('@ember/-internals/glimmer').isSerializationFirstNode;
ApplicationInstance = require('@ember/application/instance').default;
} else if (require.has('ember')) {
var _Ember = require('ember').default;
isSerializationFirstNode = _Ember.ViewUtils.isSerializationFirstNode;
ApplicationInstance = _Ember.ApplicationInstance;
} else if (window.Ember) {
isSerializationFirstNode = window.Ember.ViewUtils.isSerializationFirstNode;
ApplicationInstance = window.Ember.ApplicationInstance;
}

if (current && !_Ember) {
if (!isSerializationFirstNode || !ApplicationInstance) {
console.error(`Experimental render mode rehydrate isn't working because it couldn't find Ember via AMD or global.
See https://github.com/ember-fastboot/ember-cli-fastboot/issues/938 for the current state of the fix.`);
return;
}

if (
current &&
typeof _Ember.ViewUtils.isSerializationFirstNode === 'function' &&
_Ember.ViewUtils.isSerializationFirstNode(current.nextSibling)
typeof isSerializationFirstNode === 'function' &&
isSerializationFirstNode(current.nextSibling)
) {
_Ember.ApplicationInstance.reopen({
_bootSync: function (options) {
ApplicationInstance.reopen({
_bootSync: function(options) {
if (options === undefined) {
options = {
_renderMode: 'rehydrate',
Expand Down
Loading