Merge pull request #1011 from ember-learn/ember-composable-helpers

remove the only use of ember-composable-helpers

Author: mansona

app/components/class-field-description.gjs

@@ -1,7 +1,5 @@
 import { service } from '@ember/service';
 import Component from '@glimmer/component';
-import join from 'ember-composable-helpers/helpers/join';
-import mapBy from 'ember-composable-helpers/helpers/map-by';
 import svgJar from 'ember-svg-jar/helpers/svg-jar';
 import { LinkTo } from '@ember/routing';
 import { array, concat } from '@ember/helper';
@@ -11,6 +9,15 @@ import eq from 'ember-api-docs/helpers/eq';
 import ImportExample from 'ember-api-docs/components/import-example';
 import MarkdownToHtml from 'ember-cli-showdown/components/markdown-to-html';
 
+/**
+ * Extract the name field from the passed items an string-join them with `, ` in the middle
+ *
+ * @param {[{name: string}]} items
+ */
+function combineNames(items) {
+  return items.map((item) => item.name).join(', ');
+}
+
 export default class ClassFieldDescription extends Component {
   <template>
     {{! template-lint-disable no-invalid-interactive }}
@@ -20,9 +27,8 @@ export default class ClassFieldDescription extends Component {
           <span class="{{@type}}-name">
             {{@field.name}}
           </span>
-          {{#if @field.params}}(<span class="args">{{join
-                ", "
-                (mapBy "name" @field.params)
+          {{#if @field.params}}(<span class="args">{{combineNames
+                @field.params
               }}</span>){{/if}}
           {{#if @field.return}}
             :

ember-cli-build.js

@@ -19,9 +19,6 @@ module.exports = function (defaults) {
       sourcemap: !envIsProduction,
       overrideBrowsersList: ['default'],
     },
-    'ember-composable-helpers': {
-      only: ['join', 'map-by'],
-    },
     'asset-cache': {
       version: '4', //Might have to change this with the app build,
     },

eslint.config.mjs

@@ -43,7 +43,13 @@ export default [
    * https://eslint.org/docs/latest/use/configure/ignore
    */
   {
-    ignores: ['dist/', 'node_modules/', 'coverage/', '!**/.*'],
+    ignores: [
+      'dist/',
+      'node_modules/',
+      'coverage/',
+      '!**/.*',
+      'ember-api-docs-data',
+    ],
   },
   /**
    * https://eslint.org/docs/latest/use/configure/configuration-files#configuring-linter-options

package.json

@@ -70,7 +70,6 @@
     "ember-cli-inject-live-reload": "^2.1.0",
     "ember-cli-showdown": "^9.0.1",
     "ember-cli-terser": "^4.0.2",
-    "ember-composable-helpers": "^5.0.0",
     "ember-concurrency": "^4.0.6",
     "ember-data": "~4.12.8",
     "ember-data-fastboot": "https://github.com/kategengler/ember-data-fastboot#v0.0.1",