Fix lint

Author: RobbieTheWagner

.template-lintrc.js

@@ -5,6 +5,8 @@ module.exports = {
   rules: {
     // TODO: fix these and enable octane
     'no-action': false,
+    'no-at-ember-render-modifiers': false,
+    'no-builtin-form-components': false,
     'no-curly-component-invocation': false,
     'no-implicit-this': false,
     'no-inline-styles': false,

blueprints/docs-page/index.js

@@ -1,4 +1,3 @@
-/* eslint-env node */
 const path = require('path');
 const fs = require('fs');
 const chalk = require('chalk');
@@ -11,6 +10,7 @@ const DUMMY_APP_PATH = path.join('tests', 'dummy', 'app');
 function dedasherize(str) {
   let dedasherized = str.replace(/-/g, ' ');
 
+  // eslint-disable-next-line ember/no-string-prototype-extensions
   return stringUtil.capitalize(dedasherized);
 }
 

config/deploy.js

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 module.exports = function (deployTarget) {
   let ENV = {
     build: {},

eslint.config.mjs

@@ -43,7 +43,14 @@ export default [
    * https://eslint.org/docs/latest/use/configure/ignore
    */
   {
-    ignores: ['dist/', 'node_modules/', 'coverage/', 'test-apps/', '!**/.*'],
+    ignores: [
+      'dist/',
+      'node_modules/',
+      'coverage/',
+      'test-apps/',
+      'tmp/',
+      '!**/.*',
+    ],
   },
   /**
    * https://eslint.org/docs/latest/use/configure/configuration-files#configuring-linter-options
@@ -65,8 +72,25 @@ export default [
       parserOptions: esmParserOptions,
       globals: {
         ...globals.browser,
+        server: true,
       },
     },
+    rules: {
+      'no-unused-vars': ['error', { args: 'none' }],
+      'no-console': ['error', { allow: ['warn', 'error'] }],
+      'ember/no-incorrect-calls-with-inline-anonymous-functions': 'off',
+      'ember/require-return-from-computed': 'off',
+      'ember/no-jquery': 'error',
+
+      // TODO: enable these rules
+      'ember/classic-decorator-no-classic-methods': 'off',
+      'ember/no-classic-classes': 'off',
+      'ember/no-classic-components': 'off',
+      'ember/no-component-lifecycle-hooks': 'off',
+      'ember/no-computed-properties-in-native-classes': 'off',
+      'ember/no-private-routing-service': 'off',
+      'ember/no-runloop': 'off',
+    },
   },
   {
     files: ['tests/**/*-test.{js,gjs}'],
@@ -80,13 +104,19 @@ export default [
   {
     files: [
       '**/*.cjs',
+      'blueprints/*/index.js',
       'config/**/*.js',
+      'lib/**/*.js',
+      'sandbox/index.js',
+      'tests/dummy/config/**/*.js',
       'testem.js',
       'testem*.js',
       '.prettierrc.js',
       '.stylelintrc.js',
       '.template-lintrc.js',
+      '**/addon-docs.js',
       'ember-cli-build.js',
+      'index.js',
     ],
     plugins: {
       n,
@@ -100,6 +130,24 @@ export default [
       },
     },
   },
+  /**
+   * Node test files (mocha)
+   */
+  {
+    files: ['tests-node/**/*.js'],
+    plugins: {
+      n,
+    },
+
+    languageOptions: {
+      sourceType: 'script',
+      ecmaVersion: 'latest',
+      globals: {
+        ...globals.node,
+        ...globals.mocha,
+      },
+    },
+  },
   /**
    * ESM node files
    */

index.js

@@ -5,8 +5,8 @@ const path = require('path');
 const UnwatchedDir = require('broccoli-source').UnwatchedDir;
 const MergeTrees = require('broccoli-merge-trees');
 const Funnel = require('broccoli-funnel');
-const EmberApp = require('ember-cli/lib/broccoli/ember-app'); // eslint-disable-line n/no-unpublished-require
-const Plugin = require('broccoli-plugin');
+const EmberApp = require('ember-cli/lib/broccoli/ember-app');
+const BroccoliPlugin = require('broccoli-plugin');
 const walkSync = require('walk-sync');
 
 const LATEST_VERSION_NAME = '-latest';
@@ -463,7 +463,7 @@ function generateDefaultProject(parentAddon, addonSrcFolder) {
   return new MergeTrees(includeFunnels);
 }
 
-class FindDummyAppFiles extends Plugin {
+class FindDummyAppFiles extends BroccoliPlugin {
   build() {
     let addonPath = this.inputPaths[0];
     let paths = walkSync(addonPath, { directories: false });
@@ -476,7 +476,7 @@ class FindDummyAppFiles extends Plugin {
   }
 }
 
-class FindAddonFiles extends Plugin {
+class FindAddonFiles extends BroccoliPlugin {
   build() {
     let addonPath = this.inputPaths[0];
     let paths = addonPath ? walkSync(addonPath, { directories: false }) : [];

lib/utils/find-and-replace-in-directory.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 'use strict';
 
 const fs = require('fs-extra');

sandbox/.eslintrc.js

@@ -6,5 +6,5 @@ module.exports = {
 
   isDevelopingAddon() {
     return true;
-  }
+  },
 };