Conversation
convert quick start to gjs
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
* Updated index to use gjs * Updated introduction to use gjs * Updated arguments and attributes to use gjs * Updated conditional content to use gjs * Updated block content to use gjs * Updated helper functions to use gjs * Updated component state and actions to use gjs * Updated looping to use gjs * Updated built in components to use gjs Removed ai helper
* fixed whitespace * added missing imports * fixed import paths
Contributor
|
For an idea of the level of effort here, these are counts of Total: 274 code blocks in 42 files. Here is the status of getting these to All done 🎉 Already MergedPR #2124
PR #2126
PR #2127
PR #2118
This repo
Tutorial - generated from super rentals
|
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Use 'release' for links to API docs Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Convert routing section to route components
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
update anatomy-of-an-ember-app to gjs
minor changes to runloop
update testing tools to gjs
Co-authored-by: Katie Gengler <katie@kmg.io>
updating testing-components to gjs
Merge master into gjs branch
* Updated chapter 1 to strict * Updated chapter 2 to strict * Updated chapter 3 to strict * Partially updated chapter 4 to strict * Partially updated chapter 4 to strict * Partially updated chapter 4 to strict * Partially updated chapter 5 to strict * WIP * Partially updated chapter 5 to strict * Fixed bad patch * Partially updated chapter 6 to strict * Partially updated chapter 6 to strict * Partially updated chapter 6 to strict * Partially updated chapter 7 to strict * Partially updated chapter 7 to strict * Updated chapter 8 to strict * Updated chapter 9 to strict * Updated chapter 10 to strict * Updated chapter 12 to strict --- Commit: ember-learn/super-rentals-tutorial@cba238c Script: https://github.com/ember-learn/super-rentals-tutorial/blob/cba238c129c150a3bc0b63dfe8828ed7d3a33ab1/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/cba238c129c150a3bc0b63dfe8828ed7d3a33ab1/checks # Conflicts: # guides/release/tutorial/part-1/component-basics.md # guides/release/tutorial/part-1/orientation.md
Apply the changes to the tutorial for the gjs branch
jaredgalanis
approved these changes
Sep 26, 2025
jaredgalanis
left a comment
jaredgalanis
left a comment
Member
There was a problem hiding this comment.
Did a relatively surface level scan and it all looks okay to me. Approving so that we can move forward with this and perform any fixes needed in follow up.
Contributor
|
this PR is too big for GH to render 🙈 let's merge and fix forward, probably? |
Merge master
show the gjs warning banner on 6.7.0
Member
Author
|
We decided at the learning team meeting yesterday that we are merging this PR and any fixes can be done on a fix-forward basis. Thank you everyone for your work in getting this over the line 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The @ember-learn/tooling-core-team is in the process of migrating the guides to GJS 🎉 this is the tracking branch that can be used as a target for smaller PRs that convert individual parts of the guides to GJS
Warning
This migration assumes that the generators for GJS are in place in both ember-source and ember-cli. The core teams are working to get the generators ready for the upcoming 6.5 release so this PR should not be merged before Ember 6.5 is released.