Skip to content

Harden run-code-block server readiness and screenshot navigation retries#287

Merged
kategengler merged 6 commits into
mainfrom
copilot/fix-github-actions-failure
Jun 22, 2026
Merged

Harden run-code-block server readiness and screenshot navigation retries#287
kategengler merged 6 commits into
mainfrom
copilot/fix-github-actions-failure

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

run:server:start could report success before the local app was actually accepting connections, causing screenshot visit steps to fail intermittently. Retry handling also wasn’t resilient enough for transient startup/network races.

  • Server startup gating

    • Passes directive timeout through to server.start(...) (was parsed but not applied).
    • After log-based startup detection (expect), extracts/validates URL and blocks until the host/port accepts TCP connections.
    • Fails with stdout/stderr context and tears down the spawned server on readiness timeout.
  • Navigation retry hardening

    • Expands retryable page.goto(...) failures to include additional transient conditions (ERR_ABORTED, HTTP response failure case).
    • Increases retry budget and adds bounded exponential backoff between attempts.
    • Recreates page context between attempts to avoid stale/invalid browser state.
  • Representative change

    let stdout = await server.start(args.expect, args.timeout);
    
    let readyURL = extractURL(args.expect);
    if (readyURL) {
      await waitForServerReady(readyURL, args.timeout || 30000);
    }

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Build (release) Harden screenshot generation against transient CI navigation failures Jun 18, 2026
Copilot AI requested a review from kategengler June 18, 2026 15:58
Copilot AI changed the title Harden screenshot generation against transient CI navigation failures Harden run-code-block server readiness and screenshot navigation retries Jun 18, 2026
@kategengler kategengler marked this pull request as ready for review June 22, 2026 16:38
@kategengler kategengler merged commit f2669b1 into main Jun 22, 2026
11 of 12 checks passed
@kategengler kategengler deleted the copilot/fix-github-actions-failure branch June 22, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants