Remove dropdown option from calculatePosition (#1031)

* Remove passing component class to calculatePosition

* Fix lint

* Add in docs

* Improve docs

* Fix lint

Author: mkszepp

docs/app/templates/public-pages/docs/migrate-8-0-to-9-0.gts

@@ -41,6 +41,17 @@ import { LinkTo } from '@ember/routing';
         <code>sass-embedded</code>.
       </p>
     </li>
+    <li>
+      <p>
+        The
+        <code>dropdown</code>
+        option has been removed from
+        <code>calculatePosition</code>. Previously, this option passed the
+        current class instance to
+        <code>calculatePosition</code>.<br />
+        Note: This option was never documented.
+      </p>
+    </li>
     <li>
       <p>
         Passing

ember-basic-dropdown/src/components/basic-dropdown.gts

@@ -306,7 +306,6 @@ export default class BasicDropdown extends Component<BasicDropdownSignature> {
         previousVerticalPosition,
         renderInPlace,
         matchTriggerWidth,
-        dropdown: this,
       },
     );
     return this.applyReposition(triggerElement, dropdownElement, positionData);

ember-basic-dropdown/src/utils/calculate-position.ts

@@ -1,4 +1,3 @@
-import type BasicDropdown from '../components/basic-dropdown.gts';
 import type { VerticalPosition, HorizontalPosition } from '../types.ts';
 
 // To avoid breaking the current types export we need this
@@ -11,7 +10,6 @@ export interface CalculatePositionOptions {
   previousHorizontalPosition?: HorizontalPosition | undefined;
   previousVerticalPosition?: VerticalPosition | undefined;
   renderInPlace: boolean;
-  dropdown: BasicDropdown;
 }
 
 export type CalculatePositionResultStyle = {

test-app/tests/integration/components/basic-dropdown-test.gts

@@ -1057,13 +1057,8 @@ module('Integration | Component | basic-dropdown', function (hooks) {
     const self = this;
 
     assert.expect(4);
-    this.calculatePosition = function (
-      _triggerElement,
-      _dropdownElement,
-      _destinationElement,
-      { dropdown },
-    ) {
-      assert.ok(dropdown, 'dropdown should be passed to the component');
+    this.calculatePosition = function () {
+      assert.ok('custom calculatePosition was passed to the component');
       return {
         horizontalPosition: 'right',
         verticalPosition: 'above',
@@ -1118,9 +1113,12 @@ module('Integration | Component | basic-dropdown', function (hooks) {
       _triggerElement,
       _dropdownElement,
       _destinationElement,
-      { dropdown, renderInPlace },
+      { renderInPlace },
     ) {
-      assert.ok(dropdown, 'dropdown should be passed to the component');
+      assert.ok(
+        renderInPlace,
+        'custom calculatePosition with renderInPlace was passed to the component',
+      );
       if (renderInPlace) {
         return {
           horizontalPosition: 'right',